Skip to content

Update PieSectorDataItem import to use public API path#6605

Merged
ckifer merged 2 commits intomainfrom
copilot/update-piesectordataitem-import
Nov 12, 2025
Merged

Update PieSectorDataItem import to use public API path#6605
ckifer merged 2 commits intomainfrom
copilot/update-piesectordataitem-import

Conversation

Copy link
Contributor

Copilot AI commented Nov 11, 2025 •
edited
Loading

Description

Updates PieChartWithNeedle example to import PieSectorDataItem from the public API ('recharts') instead of internal path ('recharts/types/polar/Pie').

The type was exported in PR #6533 but the example continued using the internal path temporarily until npm publish.

Before:

import { Pie, PieChart, PieProps, Tooltip } from 'recharts';
import { PieSectorDataItem } from 'recharts/types/polar/Pie';

After:

import { Pie, PieChart, PieProps, PieSectorDataItem, Tooltip } from 'recharts';

Related Issue

Closes #[issue_number]

Follow-up to PR #6533

Motivation and Context

The PieSectorDataItem type is now part of the public API (exported from src/index.ts). Examples should reference public APIs, not internal implementation paths.

How Has This Been Tested?

  • Type-checking passes (npm run check-types-website)
  • Website tests pass (npm run test-website)
  • All unit tests pass

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or VR test, or extended an existing story or VR test to show my changes
Original prompt

This section details on the original issue you should resolve

<issue_title>Update PieSectorDataItem import to use public API path after npm publish</issue_title>
<issue_description>## Description

After PR #6533 is merged and published to npm, update the import path for PieSectorDataItem in the PieChartWithNeedle example to use the public API.

Location

www/src/docs/exampleComponents/PieChart/PieChartWithNeedle.tsx (line 2)

Current Import

import { PieSectorDataItem } from 'recharts/types/polar/Pie';

Desired Import

import { PieSectorDataItem } from 'recharts';

Context

The PieSectorDataItem type is being added to the public API in PR #6533 and is exported from src/index.ts. However, the example currently uses an internal import path because the changes haven't been published to npm yet.

References

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@PavelVanecek
Update PieSectorDataItem import to use public API path
baffb9a 
Co-authored-by: PavelVanecek <1100170+PavelVanecek@users.noreply.github.com>
Copilot AI changed the title [WIP] Update PieSectorDataItem import to public API path Update PieSectorDataItem import to use public API path Nov 11, 2025
Copilot AI requested a review from PavelVanecek November 11, 2025 15:12
@PavelVanecek PavelVanecek marked this pull request as ready for review November 12, 2025 02:13
@codecov
Copy link

codecov bot commented Nov 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.16%. Comparing base (f0260cd) to head (baffb9a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6605   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files         493      493           
  Lines       41068    41068           
  Branches     4773     4773           
=======================================
  Hits        38672    38672           
  Misses       2391     2391           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Bundle Report

Bundle size has no change ✅

@ckifer ckifer merged commit 3b11f9e into main Nov 12, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckifer ckifer ckifer approved these changes

+1 more reviewer

@PavelVanecek PavelVanecek PavelVanecek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PavelVanecek PavelVanecek

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update PieSectorDataItem import to use public API path after npm publish

3 participants

@PavelVanecek @ckifer