Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6352 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 221 221
Lines 20345 20346 +1
Branches 4171 4171
=======================================
+ Hits 19665 19666 +1
Misses 673 673
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ckifer
approved these changes
Sep 20, 2025
Member
ckifer
left a comment
There was a problem hiding this comment.
LGTM, thanks.
Still not used to AI writing PR descriptions. It's almost too much to read for a change so small 😅
Member
|
Thanks! |
Collaborator
|
I wonder how difficult is it to write a unit test for these warnings? Or how else to turn the warnings into errors? |
Member
|
I've tried in the past without success but not sure if that's changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Standardized Sankey node key generation to follow the same pattern as link keys for consistency and improved code maintainability. Updated node key to use data-attribute-based pattern node-${index}-${x}-${y} format, aligning with the existing link key pattern link-${source}-${target}-${value}.
Related Issue
#6322
Motivation and Context
The Sankey component had inconsistent key generation patterns between nodes and links. Links were using meaningful data attributes (source, target, value) while nodes were using basic array indices. This inconsistency made the codebase harder to maintain and could potentially cause React rendering issues. By aligning both components to use similar data-driven key generation approaches, we improve code consistency, maintainability, and ensure stable component identification across re-renders.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: