Remove redundant Rectangle import (and fix linter warning in the same file)#6305
Merged
ckifer merged 2 commits intorecharts:mainfrom Sep 11, 2025
Merged
Remove redundant Rectangle import (and fix linter warning in the same file)#6305ckifer merged 2 commits intorecharts:mainfrom
Rectangle import (and fix linter warning in the same file)#6305ckifer merged 2 commits intorecharts:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6305 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 221 221
Lines 20287 20287
Branches 4157 4157
=======================================
Hits 19604 19604
Misses 676 676
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ckifer
approved these changes
Sep 11, 2025
| }; | ||
|
|
||
| return <BarRectangle key={`background-bar-${i}`} {...barRectangleProps} />; | ||
| return <BarRectangle key={`background-bar-${barRectangleProps.index}`} {...barRectangleProps} />; |
Member
There was a problem hiding this comment.
ah, you fixed the linter error by tricking the linter I see. It isn't really fixed per se but 😅
Contributor
Author
There was a problem hiding this comment.
Assigning to barRectangleProps.index helps signal the intent that that value is indeed intended to be a stable key suffix, and/or could be assigned w/ a different scheme, if the array index isn't stable in some mutable-data use case 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The src/cartesian/Bar.tsx module has a redundant import of the
<Rectangle />component, that gets overwritten by the module-scopedRectangledata type. This doesn't break any code, but e.g. tsup fails to parse the project without removing it.Motivation and Context
No change to the package behavior, this is just a quality-of-life improvement to allow tsup to compile typedefs.
How Has This Been Tested?
Unit tests and linter run and pass
Screenshots (if appropriate):
Types of changes
Checklist: