Added fill color support to PolarGrid#6287
Merged
ckifer merged 1 commit intorecharts:mainfrom Sep 8, 2025
mindtraveller:main
Merged
Added fill color support to PolarGrid#6287ckifer merged 1 commit intorecharts:mainfrom mindtraveller:main
ckifer merged 1 commit intorecharts:mainfrom
mindtraveller:main
Conversation
Collaborator
|
Thanks for the PR. Looks like a rounding problem in the unit test. Which os are you using? These are usually stable from what I've seen |
Contributor
Author
|
it's because of this change: 
Reverted. doesn't worth it :) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6287 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 221 221
Lines 20182 20186 +4
Branches 4140 4144 +4
=======================================
+ Hits 19501 19505 +4
Misses 674 674
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PavelVanecek
approved these changes
Sep 8, 2025
ckifer
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#2856
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: