Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades ESLint from version 8 to version 9, migrating from the legacy .eslintrc configuration to the new flat config format (eslint.config.mjs). The upgrade includes updating related dependencies and addressing new linting requirements.
- Migrated from legacy ESLint 8 configuration to ESLint 9 flat config
- Updated ESLint plugins and dependencies to compatible versions
- Added ESLint disable comments for
react-hooks/exhaustive-depsrule violations
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated ESLint and related dependencies to version 9 compatible packages |
| eslint.config.mjs | New flat config format replacing the legacy .eslintrc configuration |
| .eslintrc | Removed legacy ESLint configuration file |
| prettier.config.mjs | New Prettier configuration in ES module format |
| .prettierrc | Removed legacy Prettier configuration file |
| stryker.config.mjs | Removed ESLint disable comment for import/no-default-export |
| src/cartesian/YAxis.tsx | Added ESLint disable comment for react-hooks/exhaustive-deps |
| src/util/useElementOffset.ts | Added ESLint disable comment for react-hooks/exhaustive-deps |
| test/helper/useEffectDebug.ts | Added ESLint disable comment for react-hooks/exhaustive-deps |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6284 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 221 221
Lines 20178 20178
Branches 4139 4139
=======================================
Hits 19499 19499
Misses 672 672
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PavelVanecek
approved these changes
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgraded to ESLint 9 using old
.eslintrcRelated Issue
Issue: #5949
Motivation and Context
It upgrade ESLint to the latest version.
Types of changes
Checklist:
Additional Context
During the migration, I don't why but 3 files get affected of
react-hooks/exhaustive-depsrule. I request maintainer to check and take appropriate action. Affected files are