Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds two new hooks, useXAxisDomain and useYAxisDomain, that allow developers to access the calculated domain values of X and Y axes in Recharts. These hooks provide access to both numerical domains (min/max ranges) and categorical domains (arrays of category values), supporting different axis types and configurations including brush interactions.
- Adds comprehensive domain selection functionality for both X and Y axes
- Includes extensive test coverage for various axis configurations and edge cases
- Provides Storybook integration and documentation for the new hooks
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test/hooks/useAxisDomain.spec.tsx |
Comprehensive test suite covering various axis configurations, domain types, and edge cases |
storybook/storybook-addon-recharts/inspectors/YAxisDomainInspector.tsx |
Storybook inspector component for Y-axis domain visualization |
storybook/storybook-addon-recharts/inspectors/XAxisDomainInspector.tsx |
Storybook inspector component for X-axis domain visualization |
storybook/storybook-addon-recharts/inspectors/CartesianChartInspector.tsx |
Integration of new domain inspectors into Storybook |
storybook/stories/API/hooks/useAxisDomain.mdx |
Documentation for the new hooks with usage examples |
src/util/ReactUtils.ts |
Minor comment correction for deprecated function |
src/state/cartesianAxisSlice.ts |
Export of default axis ID constant |
src/hooks.ts |
Implementation of the new useXAxisDomain and useYAxisDomain hooks |
Bundle ReportChanges will increase total bundle size by 4.8kB (0.2%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: recharts/bundle-es6Assets Changed:
view changes for bundle: recharts/bundle-umdAssets Changed:
view changes for bundle: recharts/bundle-cjsAssets Changed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6201 +/- ##
=======================================
Coverage 96.69% 96.70%
=======================================
Files 221 221
Lines 19870 19880 +10
Branches 4098 4102 +4
=======================================
+ Hits 19214 19224 +10
Misses 650 650
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Includes documentation
Related Issue
#6021
Screenshots (if appropriate):
Types of changes
Checklist: