Fix stacked charts with duplicate categorical data#6194
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in stacked charts where duplicate categorical data causes rendering issues. The fix ensures that when allowDuplicatedCategory is enabled, the chart uses index-based positioning instead of relying on the data key value for tooltip positioning.
Key Changes
- Modified
combineDisplayedStackedDatato use index-based positioning whenallowDuplicatedCategoryis true - Added comprehensive unit tests to verify the fix for stacked bar charts with duplicate categorical data
- Added visual regression tests to prevent future regressions
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/state/selectors/combiners/combineDisplayedStackedData.ts | Core fix: uses index instead of data key value when allowDuplicatedCategory is enabled |
| test/cartesian/Bar.truncateByDomain.spec.tsx | Unit tests covering the duplicate categorical data scenario with selector validation |
| test-vr/tests/Bar.6192.spec-vr.tsx | Visual regression test with comprehensive dataset showing the bug fix in action |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6194 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 222 222
Lines 20019 20025 +6
Branches 4140 4140
=======================================
+ Hits 19368 19374 +6
Misses 645 645
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 2 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: recharts/bundle-cjsAssets Changed:
view changes for bundle: recharts/bundle-umdAssets Changed:
view changes for bundle: recharts/bundle-es6Assets Changed:
|
ckifer
approved these changes
Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I missed this use-case when refactoring.
Related Issue
Fixes #6192
How Has This Been Tested?
unit + VR tests
Screenshots (if appropriate):
https://github.com/recharts/recharts/pull/6194/files#diff-915bfdd6ee0e23439c6b300c92d732954fd0e01d4b409d82d8d369749877e1a9
Types of changes
Checklist: