Skip to content

Downgrade vitest to resolve typescript error#5902

Merged
PavelVanecek merged 1 commit into3.xfrom
vitest-downgrade
Jun 4, 2025
Merged

Downgrade vitest to resolve typescript error#5902
PavelVanecek merged 1 commit into3.xfrom
vitest-downgrade

Conversation

@PavelVanecek
Copy link
Copy Markdown
Collaborator

@PavelVanecek PavelVanecek commented Jun 4, 2025

@PavelVanecek PavelVanecek requested a review from Copilot June 4, 2025 10:18
Copilot AI reviewed Jun 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades the vitest dependencies to resolve a TypeScript error.

  • Downgraded "@vitest/coverage-v8" version from "^3.1.1" to "3.1.x".
  • Downgraded "vitest" version from "^3.1.1" to "3.1.x".
Comments suppressed due to low confidence (2)

package.json:132

  • Using a version range '3.1.x' may include unintended patch versions; please verify that this restriction fully addresses the TypeScript error without introducing other compatibility issues.
    "@vitest/coverage-v8": "3.1.x",

package.json:168

  • Ensure that downgrading vitest to '3.1.x' resolves the TypeScript error without affecting any required features; confirm that this version constraint aligns with the overall dependency strategy.
    "vitest": "3.1.x",

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.61%. Comparing base (9ac7102) to head (e79e99f).
Report is 8 commits behind head on 3.x.

Additional details and impacted files 
@@            Coverage Diff             @@
##              3.x    #5902      +/-   ##
==========================================
+ Coverage   95.58%   95.61%   +0.02%     
==========================================
  Files         186      187       +1     
  Lines       18987    18975      -12     
  Branches     3823     3805      -18     
==========================================
- Hits        18149    18143       -6     
+ Misses        832      826       -6     
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 4, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 12.03kB (0.53%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
recharts/bundle-cjs 963.97kB 6.26kB (0.65%) ⬆️
recharts/bundle-es6 829.35kB -1.21kB (-0.15%) ⬇️
recharts/bundle-umd 492.46kB 6.98kB (1.44%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: recharts/bundle-es6

Assets Changed:

Asset Name Size Change Total Size Change (%)
chart/Treemap.js 143 bytes 26.24kB 0.55%
chart/Sankey.js 96 bytes 24.04kB 0.4%
polar/Pie.js 92 bytes 22.27kB 0.41%
util/ChartUtils.js 226 bytes 20.65kB 1.11%
polar/Radar.js -47 bytes 13.52kB -0.35%
util/types.js 679 bytes 13.19kB 5.43% ⚠️
cartesian/CartesianAxis.js 93 bytes 12.43kB 0.75%
state/selectors/selectors.js 98 bytes 10.68kB 0.93%
chart/SunburstChart.js 92 bytes 10.48kB 0.89%
component/DefaultLegendContent.js 98 bytes 6.78kB 1.47%
util/CartesianUtils.js 53 bytes 5.67kB 0.94%
component/DefaultTooltipContent.js 98 bytes 5.44kB 1.83%
util/ReactUtils.js -318 bytes 5.19kB -5.78%
chart/PolarChart.js (New) 4.59kB 4.59kB 100.0% 🚀
util/DataUtils.js 92 bytes 4.21kB 2.23%
chart/CartesianChart.js -2.91kB 3.81kB -43.31%
state/selectors/selectChartOffset.js 92 bytes 3.69kB 2.56%
container/RootSurface.js 10 bytes 3.15kB 0.32%
chart/CategoricalChart.js (New) 2.2kB 2.2kB 100.0% 🚀
chart/RadialBarChart.js 313 bytes 861 bytes 57.12% ⚠️
chart/RadarChart.js 428 bytes 848 bytes 101.9% ⚠️
chart/PieChart.js 319 bytes 842 bytes 60.99% ⚠️
chart/ComposedChart.js 266 bytes 573 bytes 86.64% ⚠️
chart/BarChart.js 197 bytes 571 bytes 52.67% ⚠️
chart/ScatterChart.js 193 bytes 571 bytes 51.06% ⚠️
chart/FunnelChart.js 187 bytes 569 bytes 48.95% ⚠️
chart/AreaChart.js 270 bytes 565 bytes 91.53% ⚠️
util/isWellBehavedNumber.js 103 bytes 174 bytes 145.07% ⚠️
chart/generateCategoricalChart.js (Deleted) -8.96kB 0 bytes -100.0% 🗑️
view changes for bundle: recharts/bundle-umd

Assets Changed:

Asset Name Size Change Total Size Change (%)
Recharts.js 6.98kB 492.46kB 1.44%
view changes for bundle: recharts/bundle-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
chart/Treemap.js 238 bytes 27.81kB 0.86%
chart/Sankey.js 281 bytes 25.58kB 1.11%
polar/Pie.js 124 bytes 23.97kB 0.52%
util/ChartUtils.js 383 bytes 22.66kB 1.72%
polar/Radar.js -61 bytes 14.93kB -0.41%
cartesian/CartesianAxis.js 214 bytes 13.64kB 1.59%
util/types.js 679 bytes 13.56kB 5.27% ⚠️
state/selectors/selectors.js 213 bytes 12.34kB 1.76%
chart/SunburstChart.js 210 bytes 11.74kB 1.82%
component/DefaultLegendContent.js 213 bytes 7.75kB 2.83%
component/DefaultTooltipContent.js 213 bytes 6.49kB 3.39%
util/CartesianUtils.js 37 bytes 6.11kB 0.61%
util/ReactUtils.js -291 bytes 5.79kB -4.78%
chart/PolarChart.js (New) 5.57kB 5.57kB 100.0% 🚀
util/DataUtils.js 211 bytes 5.05kB 4.36%
chart/CartesianChart.js -2.92kB 4.78kB -37.92%
state/selectors/selectChartOffset.js 210 bytes 4.27kB 5.17% ⚠️
container/RootSurface.js 57 bytes 4.12kB 1.4%
chart/CategoricalChart.js (New) 3.07kB 3.07kB 100.0% 🚀
chart/RadialBarChart.js 982 bytes 1.7kB 136.96% ⚠️
chart/RadarChart.js 1.1kB 1.68kB 189.31% ⚠️
chart/PieChart.js 988 bytes 1.67kB 145.29% ⚠️
chart/ComposedChart.js 913 bytes 1.39kB 192.62% ⚠️
chart/ScatterChart.js 840 bytes 1.38kB 154.7% ⚠️
chart/FunnelChart.js 835 bytes 1.38kB 153.49% ⚠️
chart/BarChart.js 844 bytes 1.38kB 158.95% ⚠️
chart/AreaChart.js 917 bytes 1.37kB 201.98% ⚠️
util/isWellBehavedNumber.js 141 bytes 336 bytes 72.31% ⚠️
chart/generateCategoricalChart.js (Deleted) -9.96kB 0 bytes -100.0% 🗑️

@PavelVanecek
Copy link
Copy Markdown
Collaborator Author

PavelVanecek commented Jun 4, 2025

Why does change in the test dependencies change bundle size?

@PavelVanecek PavelVanecek merged commit dd45b4d into 3.x Jun 4, 2025
21 checks passed
@PavelVanecek PavelVanecek deleted the vitest-downgrade branch June 4, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PavelVanecek