AreaChart: Respect baseValue of AreaChart, but allow override from Area#3140
Merged
ckifer merged 2 commits intorecharts:masterfrom Jan 4, 2023
Merged
Conversation
Contributor
Author
|
TODO:
|
ckifer
approved these changes
Jan 4, 2023
Member
There was a problem hiding this comment.
Code change looks good to me! Easy fix
@nikolasrieble Question would be do you want me to merge this now or wait for the TODO items?
Contributor
Author
|
I guess as this is a fix restoring a previously existing functionality, this is good to go. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug, introduced in #3013, which neglects to respect the AreaChart baseValue and thereby breaks existing charts.
Related Issue
#3051
How Has This Been Tested?
I tested the change locally by running the demo project, verifying that the baseValue of the AreaChart is effective by itself, and that overriding it per Area component is possible.
Screenshots (if appropriate):
Types of changes
Checklist: