This repository was archived by the owner on Mar 2, 2026. It is now read-only.
[SYCL][Graph] Revise undefined behaviour with no_cycle_check#263
Merged
Bensuo merged 1 commit intosycl-graph-updatefrom Jul 14, 2023
Merged
[SYCL][Graph] Revise undefined behaviour with no_cycle_check#263Bensuo merged 1 commit intosycl-graph-updatefrom
Bensuo merged 1 commit intosycl-graph-updatefrom
Conversation
- Change wording around undefined behaviour when creating a cycle with no checks - UB is created at point of adding the cycle, not at finalize.
EwanC
approved these changes
Jul 13, 2023
mfrancepillois
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change we would need to specially handle cycles being added when checks are disabled to keep the graph in a reasonable state for future operations.