Skip to content

Use URL almost everywhere#6408

Merged
SimplyDanny merged 12 commits intowindows-supportfrom
url-almost-everywhere
Jan 23, 2026
Merged

Use URL almost everywhere#6408
SimplyDanny merged 12 commits intowindows-supportfrom
url-almost-everywhere

Conversation

@SimplyDanny
Copy link
Collaborator

@SimplyDanny SimplyDanny commented Jan 3, 2026 •
edited
Loading

Resolves #6351.
Resolves #6352.

@SwiftLintBot
Copy link

SwiftLintBot commented Jan 3, 2026 •
edited
Loading

1 Warning
⚠️ Big PR
19 Messages
📖 Building this branch resulted in a binary size of 27313.98 KiB vs 27232.8 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 0.8 s vs 0.79 s on main (1% slower).
📖 Linting Alamofire with this PR took 1.05 s vs 1.08 s on main (2% faster).
📖 Linting Brave with this PR took 7.43 s vs 7.29 s on main (1% slower).
📖 Linting DuckDuckGo with this PR took 25.04 s vs 24.68 s on main (1% slower).
📖 Linting Firefox with this PR took 11.9 s vs 11.79 s on main (0% slower).
📖 Linting Kickstarter with this PR took 8.19 s vs 8.1 s on main (1% slower).
📖 Linting Moya with this PR took 0.46 s vs 0.45 s on main (2% slower).
📖 Linting NetNewsWire with this PR took 2.52 s vs 2.48 s on main (1% slower).
📖 Linting Nimble with this PR took 0.71 s vs 0.72 s on main (1% faster).
📖 Linting PocketCasts with this PR took 7.57 s vs 7.36 s on main (2% slower).
📖 Linting Quick with this PR took 0.44 s vs 0.43 s on main (2% slower).
📖 Linting Realm with this PR took 3.4 s vs 3.36 s on main (1% slower).
📖 Linting Sourcery with this PR took 1.88 s vs 1.89 s on main (0% faster).
📖 Linting Swift with this PR took 4.54 s vs 4.49 s on main (1% slower).
📖 Linting SwiftLintPerformanceTests with this PR took 0.08 s vs 0.34 s on main (76% faster).
📖 Linting VLC with this PR took 1.2 s vs 1.17 s on main (2% slower).
📖 Linting Wire with this PR took 19.04 s vs 18.67 s on main (1% slower).
📖 Linting WordPress with this PR took 12.65 s vs 12.42 s on main (1% slower).

Generated by 🚫 Danger

@SimplyDanny SimplyDanny force-pushed the url-almost-everywhere branch 20 times, most recently from 27785a7 to 3f8ba86 Compare January 11, 2026 14:11
@SimplyDanny SimplyDanny force-pushed the url-almost-everywhere branch from c5bfa40 to 665f36b Compare January 11, 2026 20:01
@SimplyDanny SimplyDanny marked this pull request as ready for review January 11, 2026 20:33
@SimplyDanny SimplyDanny mentioned this pull request Jan 11, 2026
Closed
compnerd
compnerd reviewed Jan 12, 2026
View reviewed changes
Copy link
Contributor

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go through this extremely carefully, but it does seem like it is a significant improvement. Some of this should actually improve performance too (due to the migration to the new API constructs).

@SimplyDanny SimplyDanny force-pushed the url-almost-everywhere branch 3 times, most recently from 75641b7 to 1bf2f3a Compare January 15, 2026 22:07
@SimplyDanny SimplyDanny mentioned this pull request Jan 15, 2026
Closed
2 tasks
compnerd
compnerd reviewed Jan 18, 2026
View reviewed changes
@SimplyDanny SimplyDanny mentioned this pull request Jan 19, 2026
Open
@SimplyDanny SimplyDanny force-pushed the url-almost-everywhere branch 4 times, most recently from e382eca to 030e114 Compare January 23, 2026 20:22
compnerd and others added 12 commits January 23, 2026 23:41
@compnerd @SimplyDanny
Fix Windows path handling in various places
5a86425 
An assortment of fixes that improve the test coverage on Windows. With
this set, local testing reveals 1 failure (RemoteCycleDetection) and
another set of test failures due to Windows globbing not matching the
POSIX semantics.

Co-authored-by: Roman Lavrov <roman.lavrov@thebrowser.company>
@SimplyDanny
Use URL for file paths throughout the code base
44a152a 
# Conflicts:
#	Source/SwiftLintFramework/Extensions/FileManager+SwiftLint.swift
#	Tests/IntegrationTests/ConfigPathResolutionTests.swift
@SimplyDanny
Extend basic globbing on Windows
5a4e0c0
@SimplyDanny
Assume absolute path patterns
e880d37
@SimplyDanny
Use variable for system drive
a2b28b3
@SimplyDanny
Rename property
9e6e521
@SimplyDanny
Use relative display path in output for duplicated files
e2df4e6
@SimplyDanny
Run test on all macOS versions in the same way
85b509d
@SimplyDanny
Use URL enumerator
2518079
@SimplyDanny
Run ConfigPathResolutionTests with Bazel
53133f3
@SimplyDanny
Add changelog entry
fc3a5ff
@SimplyDanny
Run all tests and lint codebase on Windows
d7c5a7d
@SimplyDanny SimplyDanny force-pushed the url-almost-everywhere branch from 030e114 to d7c5a7d Compare January 23, 2026 22:42
@SimplyDanny SimplyDanny changed the base branch from main to windows-support January 23, 2026 22:43
@SimplyDanny SimplyDanny merged commit 6075f5f into windows-support Jan 23, 2026
27 checks passed
@SimplyDanny SimplyDanny deleted the url-almost-everywhere branch January 23, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@compnerd compnerd compnerd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix all tests failing on Windows Fix Glob filtering for included/excluded paths on Windows

3 participants

@SimplyDanny @SwiftLintBot @compnerd