Add logic to exclude async without await rule for concurrent function#6284
Merged
SimplyDanny merged 2 commits intorealm:mainfrom Oct 8, 2025
Merged
Conversation
Generated by 🚫 Danger |
SimplyDanny
requested changes
Oct 7, 2025
Collaborator
SimplyDanny
left a comment
There was a problem hiding this comment.
Thank you for the prompt fix! I came up with this other case for closures that we should consider too.
Source/SwiftLintBuiltInRules/Rules/Lint/AsyncWithoutAwaitRuleExamples.swift
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Lint/AsyncWithoutAwaitRule.swift
Outdated
Show resolved
Hide resolved
SimplyDanny
approved these changes
Oct 8, 2025
Collaborator
SimplyDanny
left a comment
There was a problem hiding this comment.
Thanks again @nandhinisubbu! Looks good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix - #6283