Skip to content

Exclude explicit system modules from duplicate_imports analysis#6203

Merged
SimplyDanny merged 1 commit intomainfrom
explicit-system-modules
Aug 24, 2025
Merged

Exclude explicit system modules from duplicate_imports analysis#6203
SimplyDanny merged 1 commit intomainfrom
explicit-system-modules

Conversation

@SimplyDanny
Copy link
Collaborator

Resolves #6098.

@SwiftLintBot
Copy link

1 Warning
⚠️ This PR may need tests.
19 Messages
📖 Building this branch resulted in a binary size of 25538.37 KiB vs 25521.05 KiB when built on main (0% larger).
📖 Linting Aerial with this PR took 1.06 s vs 1.06 s on main (0% slower).
📖 Linting Alamofire with this PR took 1.42 s vs 1.42 s on main (0% slower).
📖 Linting Brave with this PR took 9.62 s vs 9.6 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 27.05 s vs 27.09 s on main (0% faster).
📖 Linting Firefox with this PR took 14.62 s vs 14.59 s on main (0% slower).
📖 Linting Kickstarter with this PR took 10.84 s vs 10.85 s on main (0% faster).
📖 Linting Moya with this PR took 0.57 s vs 0.57 s on main (0% slower).
📖 Linting NetNewsWire with this PR took 3.25 s vs 3.25 s on main (0% slower).
📖 Linting Nimble with this PR took 0.86 s vs 0.86 s on main (0% slower).
📖 Linting PocketCasts with this PR took 9.57 s vs 9.48 s on main (0% slower).
📖 Linting Quick with this PR took 0.5 s vs 0.5 s on main (0% slower).
📖 Linting Realm with this PR took 4.86 s vs 4.88 s on main (0% faster).
📖 Linting Sourcery with this PR took 2.49 s vs 2.49 s on main (0% slower).
📖 Linting Swift with this PR took 5.73 s vs 5.72 s on main (0% slower).
📖 Linting VLC with this PR took 1.51 s vs 1.52 s on main (0% faster).
📖 Linting Wire with this PR took 23.09 s vs 23.06 s on main (0% slower).
📖 Linting WordPress with this PR took 13.85 s vs 13.86 s on main (0% faster).
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/BraveWallet/Crypto/Accounts/Details/AccountDetailsView.swift:12:1: Warning: Imports should be unique (duplicate_imports)

Generated by 🚫 Danger

@SimplyDanny SimplyDanny merged commit 6150721 into main Aug 24, 2025
22 checks passed
@SimplyDanny SimplyDanny deleted the explicit-system-modules branch August 24, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive in "duplicate_imports" corner case

2 participants