Skip to content

Ignore locally defined count identifiers in empty_count rule#6202

Merged
SimplyDanny merged 1 commit intomainfrom
empty-count
Aug 24, 2025
Merged

Ignore locally defined count identifiers in empty_count rule#6202
SimplyDanny merged 1 commit intomainfrom
empty-count

Conversation

@SimplyDanny
Copy link
Collaborator

Fixes #5326.

@SwiftLintBot
Copy link

SwiftLintBot commented Aug 23, 2025

1 Warning
⚠️ This PR may need tests.
143 Messages
📖 Building this branch resulted in a binary size of 26798.35 KiB vs 26404.8 KiB when built on main (1% larger).
📖 Linting Aerial with this PR took 0.82 s vs 0.82 s on main (0% slower).
📖 Linting Alamofire with this PR took 1.02 s vs 1.02 s on main (0% slower).
📖 Linting Brave with this PR took 7.01 s vs 7.03 s on main (0% faster).
📖 Linting DuckDuckGo with this PR took 19.99 s vs 20.03 s on main (0% faster).
📖 Linting Firefox with this PR took 10.43 s vs 10.45 s on main (0% faster).
📖 Linting Kickstarter with this PR took 7.76 s vs 7.75 s on main (0% slower).
📖 Linting Moya with this PR took 0.45 s vs 0.45 s on main (0% slower).
📖 Linting NetNewsWire with this PR took 2.38 s vs 2.39 s on main (0% faster).
📖 Linting Nimble with this PR took 0.64 s vs 0.64 s on main (0% slower).
📖 Linting PocketCasts with this PR took 7.26 s vs 7.22 s on main (0% slower).
📖 Linting Quick with this PR took 0.42 s vs 0.41 s on main (2% slower).
📖 Linting Realm with this PR took 3.49 s vs 3.48 s on main (0% slower).
📖 Linting Sourcery with this PR took 1.87 s vs 1.85 s on main (1% slower).
📖 Linting Swift with this PR took 4.31 s vs 4.3 s on main (0% slower).
📖 Linting VLC with this PR took 1.12 s vs 1.13 s on main (0% faster).
📖 Linting Wire with this PR took 16.98 s vs 16.99 s on main (0% faster).
📖 Linting WordPress with this PR took 10.02 s vs 10.01 s on main (0% slower).
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Data/models/WalletUserAssetGroup.swift:72:8: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Data/models/PlaylistItem.swift:359:7: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Brave: /ios/brave-ios/Sources/Data/models/PlaylistItem.swift:367:92: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/Autofill/AutofillPixelReporter.swift:319:66: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/Autofill/AutofillPixelReporter.swift:338:12: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/Autofill/AutofillPixelReporter.swift:352:12: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/Autofill/AutofillPixelReporter.swift:362:12: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/BrowserServicesKit/SmarterEncryption/Store/AppHTTPSUpgradeStore.swift:186:22: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/Crashes/Mach-O/section+helpers.swift:34:15: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /SharedPackages/BrowserServicesKit/Sources/PrivacyDashboard/ServerTrustViewModel.swift:132:15: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /macOS/DuckDuckGo/Fire/View/FirePopoverViewController.swift:461:67: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /macOS/DuckDuckGo/Fire/View/FirePopoverViewController.swift:473:67: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /iOS/AutofillCredentialProvider/CredentialProvider/CredentialProviderList/CredentialProviderListViewModel.swift:88:41: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /iOS/Core/BookmarksStateValidation.swift:62:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/SyncPromoManager.swift:63:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/SyncPromoManager.swift:71:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/CreditCardManagement/List/AutofillCreditCardListViewModel.swift:73:41: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/CreditCardManagement/List/AutofillCreditCardListViewModel.swift:77:47: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/UnprotectedSitesViewController.swift:116:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AutofillLoginListViewModel.swift:139:41: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in DuckDuckGo: /iOS/DuckDuckGo/AutofillSurveyManager.swift:115:12: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Features/SortFilter/HeaderView/PillButtons.swift:91:36: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Kickstarter: /Library/ViewModels/FindFriendsFriendFollowCellViewModel.swift:85:31: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in NetNewsWire: /Shared/Extensions/NSAttributedString+NetNewsWire.swift:271:6: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in NetNewsWire: /Modules/Account/Sources/Account/NewsBlur/NewsBlurAccountDelegate.swift:263:40: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in PocketCasts: /podcasts/AEXML.swift:217:15: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in PocketCasts: /podcasts/Sharing/SharingModal.swift:299:15: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in PocketCasts: /podcasts/MultiSelectFooterView.swift:100:15: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in PocketCasts: /podcasts/Strings+L10n.swift:99:12: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in PocketCasts: /podcasts/UpNextViewController+Table.swift:20:20: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in PocketCasts: /podcasts/GridBadgeView.swift:35:15: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in PocketCasts: /podcasts/PodcastBundleCountView.swift:18:15: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Sourcery: /SourceryTests/Stub/Performance-Code/Kiosk/App/Models/SaleArtworkViewModel.swift:155:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafeRawPointer.swift:1125:24: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafeRawPointer.swift:1186:7: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafeRawPointer.swift:1240:7: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/DictionaryStorage.swift:390:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/DictionaryStorage.swift:391:11: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/NativeDictionary.swift:629:8: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/NativeDictionary.swift:639:10: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ArrayShared.swift:41:6: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ArrayShared.swift:276:26: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Array.swift:947:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Array.swift:951:8: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ArraySlice.swift:712:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ArraySlice.swift:713:8: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ArraySlice.swift:741:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ArraySlice.swift:745:8: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Dump.swift:105:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Dump.swift:202:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/DebuggerSupport.swift:144:27: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/DebuggerSupport.swift:156:20: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/DebuggerSupport.swift:231:29: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/DebuggerSupport.swift:232:9: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/StringLegacy.swift:31:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/StringLegacy.swift:33:14: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Misc.swift:71:9: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Misc.swift:111:9: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Repeat.swift:40:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Hasher.swift:119:26: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Hasher.swift:205:26: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Hasher.swift:461:24: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Span/MutableSpan.swift:98:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Span/RawSpan.swift:306:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/Span/Span.swift:162:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/NativeSet.swift:695:8: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/NativeSet.swift:703:10: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ArrayBody.swift:30:24: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/DictionaryBridging.swift:316:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/DictionaryBridging.swift:317:11: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafePointer.swift:892:24: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafePointer.swift:967:24: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafePointer.swift:1002:7: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafePointer.swift:1059:7: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafePointer.swift:1103:7: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafePointer.swift:1143:7: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/UnsafePointer.swift:1183:24: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ContiguousArray.swift:604:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ContiguousArray.swift:608:8: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/RangeReplaceableCollection.swift:398:8: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/core/ContiguousArrayBuffer.swift:1127:6: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncDropFirstSequence.swift:43:18: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncDropFirstSequence.swift:162:18: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Deque/Deque+Collection.swift:533:18: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Deque/Deque+Collection.swift:537:10: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncPrefixSequence.swift:43:18: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Deque/Deque+UnsafeHandle.swift:224:12: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Deque/Deque+UnsafeHandle.swift:227:11: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/Deque/Deque+UnsafeHandle.swift:305:11: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncStreamBuffer.swift:131:12: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncStreamBuffer.swift:148:25: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncStreamBuffer.swift:195:23: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncStreamBuffer.swift:359:12: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncStreamBuffer.swift:376:25: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/public/Concurrency/AsyncStreamBuffer.swift:432:23: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Swift: /stdlib/private/SwiftPrivateThreadExtras/ThreadBarriers.swift:68:6: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Wire: /wire-ios/Wire-iOS/Sources/UserInterface/ConversationList/ZMConversation+Status.swift:514:84: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/Proteus/ProteusService.swift:306:15: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Source/Utilis/CryptoBox.swift:160:12: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in Wire: /wire-ios-data-model/Tests/Source/Model/UserClient/UserClientTests.swift:48:19: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:126:38: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift:133:41: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailToolbar.swift:278:20: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/Controllers/ReaderStreamViewController.swift:1213:13: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Post/Revisions/RevisionsTableViewController.swift:250:39: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Post/Revisions/RevisionsTableViewController.swift:256:38: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Support/LogOutActionHandler.swift:29:15: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Jetpack/Jetpack Scan/JetpackScanCoordinator.swift:389:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Me/Me Main/MeViewController.swift:503:15: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Stats/Insights/StatsTotalInsightsCell.swift:300:34: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Stats/Charts/PeriodChart.swift:168:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Stats/Charts/PeriodChart.swift:172:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Stats/Charts/PeriodChart.swift:176:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Stats/Charts/PeriodChart.swift:180:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Stats/Charts/PostChart.swift:129:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Stats/Charts/PostChart.swift:133:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Stats/Helpers/SiteStatsImmuTableRows.swift:76:31: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Stats/Helpers/SiteStatsImmuTableRows.swift:84:31: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Media/External/ExternalMediaSelectionTitleView.swift:38:39: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Media/External/ExternalMediaSelectionTitleView.swift:39:30: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Media/External/ExternalMediaSelectionTitleView.swift:40:12: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Apps/Reader/ReaderTabViewController.swift:123:40: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /WordPress/Classes/Utility/Migration/ContentMigrationCoordinator.swift:138:16: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /Tests/KeystoneTests/Tests/Services/ReaderTopicServiceTest.swift:385:23: Error: Prefer checking isEmpty over comparing count to zero (empty_count)
📖 This PR fixed a violation in WordPress: /Tests/KeystoneTests/Tests/Services/ReaderTopicServiceTest.swift:390:23: Error: Prefer checking isEmpty over comparing count to zero (empty_count)

Generated by 🚫 Danger

@SimplyDanny
Copy link
Collaborator Author

Requires SwiftSyntax >=6.2 to have the library available in Bazel.

@SimplyDanny SimplyDanny force-pushed the empty-count branch 4 times, most recently from 387ee8b to 80fd88e Compare August 24, 2025 17:02
@SimplyDanny SimplyDanny enabled auto-merge (squash) August 24, 2025 17:42
@SimplyDanny SimplyDanny merged commit 8ada387 into main Aug 24, 2025
22 checks passed
@SimplyDanny SimplyDanny deleted the empty-count branch August 24, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

empty_count rule triggers on local symbols

2 participants