Add support for regex pattern in the option of the rule.#6092
Merged
SimplyDanny merged 7 commits intorealm:mainfrom Jun 25, 2025
Merged
Add support for regex pattern in the option of the rule.#6092SimplyDanny merged 7 commits intorealm:mainfrom
SimplyDanny merged 7 commits intorealm:mainfrom
Conversation
338520a to
a4bc8e9
Compare
Generated by 🚫 Danger |
a4bc8e9 to
7dd38f9
Compare
SimplyDanny
requested changes
Jun 20, 2025
Collaborator
SimplyDanny
left a comment
There was a problem hiding this comment.
Thank you for the implementation!
Please consider my remarks mainly about error handling in case of invalid exclude patterns.
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FileNameRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FileNameRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FileNameRule.swift
Outdated
Show resolved
Hide resolved
7dd38f9 to
d190ac4
Compare
SimplyDanny
reviewed
Jun 21, 2025
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/FileNameConfiguration.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/FileNameConfiguration.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/FileNameConfiguration.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/FileNameConfiguration.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/FileNameConfiguration.swift
Show resolved
Hide resolved
bf4066e to
4001b4c
Compare
Collaborator
|
Rebased to take new required build steps into account. |
SimplyDanny
approved these changes
Jun 24, 2025
Collaborator
SimplyDanny
left a comment
There was a problem hiding this comment.
Should be good to go now. Thanks again for all the work, @Ueeek!
Contributor
Author
|
@SimplyDanny Thank you so much for your review and help😁😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #6066