Allow prefer_key_paths to ignore identity closures ({ $0 })#6068
Merged
SimplyDanny merged 5 commits intorealm:mainfrom Aug 14, 2025
Merged
Conversation
2 tasks
Generated by 🚫 Danger |
2 tasks
SimplyDanny
requested changes
Jun 19, 2025
Collaborator
SimplyDanny
left a comment
There was a problem hiding this comment.
Looks good in general. Thanks!
Please see my comments and rebase your branch to make all tests run (there are relevant fixes on main).
| identifier: "prefer_key_path", | ||
| name: "Prefer Key Path", | ||
| description: "Use a key path argument instead of a closure with property access", | ||
| description: """ |
Collaborator
There was a problem hiding this comment.
Let's keep the existing description as it's currently also used as the violation message and add a rational property instead to explain this detail.
0b22e4f to
cbf90c0
Compare
Contributor
Author
|
Ready for re-review @SimplyDanny Not sure what is causing the buildkite/swiftlint/bazel and buildkite/swiftlint/registration CI steps to fail, as I ran both command sequences locally and they succeed. They seem to be linker issues caused by some TSan symbols, so perhaps caused by some caching issue? Thanks 🙏🏼 |
SimplyDanny
approved these changes
Aug 14, 2025
Collaborator
SimplyDanny
left a comment
There was a problem hiding this comment.
I found a few more stylistic issue. Other than that, it looks good!
Source/SwiftLintBuiltInRules/Rules/Idiomatic/PreferKeyPathRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/PreferKeyPathRule.swift
Outdated
Show resolved
Hide resolved
Add new `ignore_identity_closures` parameter to `prefer_key_paths` rule
to skip conversion of identity closures (`{ $0 }`) to identity key
paths (`\self`).
Add a small note to the rule description stating that identity key path
conversion is Swift 6+ only.
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
ca999dc to
86890ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new
ignore_identity_closuresparameter toprefer_key_pathsrule to skip conversion of identity closures ({ $0 }) to identity key paths (\self).Add a small note to the rule description stating that identity key path conversion is Swift 6+ only.