Skip to content

#6054: Fix false positive for Actor-conforming delegate protocols in class_delegate_protocol rule#6067

Merged
SimplyDanny merged 3 commits intorealm:mainfrom
imsonalbajaj:main-6054-warning_actor_delegate_protocol
Jun 15, 2025
Merged

#6054: Fix false positive for Actor-conforming delegate protocols in class_delegate_protocol rule#6067
SimplyDanny merged 3 commits intorealm:mainfrom
imsonalbajaj:main-6054-warning_actor_delegate_protocol

Conversation

@imsonalbajaj
Copy link
Contributor

@imsonalbajaj imsonalbajaj commented Apr 25, 2025

This PR fixes a false positive in the class_delegate_protocol rule by excluding protocols that inherit from Actor

@SwiftLintBot
Copy link

SwiftLintBot commented Apr 25, 2025 •
edited
Loading

18 Messages
📖 Building this branch resulted in a binary size of 25036.59 KiB vs 25052.02 KiB when built on main (-1% smaller).
📖 Linting Aerial with this PR took 0.22 s vs 0.18 s on main (22% slower).
📖 Linting Alamofire with this PR took 0.17 s vs 0.17 s on main (0% slower).
📖 Linting Brave with this PR took 0.7 s vs 0.7 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 5.2 s vs 5.19 s on main (0% slower).
📖 Linting Firefox with this PR took 0.97 s vs 0.97 s on main (0% slower).
📖 Linting Kickstarter with this PR took 0.69 s vs 0.7 s on main (1% faster).
📖 Linting Moya with this PR took 0.13 s vs 0.13 s on main (0% slower).
📖 Linting NetNewsWire with this PR took 0.28 s vs 0.29 s on main (3% faster).
📖 Linting Nimble with this PR took 0.15 s vs 0.15 s on main (0% slower).
📖 Linting PocketCasts with this PR took 0.66 s vs 0.68 s on main (2% faster).
📖 Linting Quick with this PR took 0.12 s vs 0.13 s on main (7% faster).
📖 Linting Realm with this PR took 0.41 s vs 0.41 s on main (0% slower).
📖 Linting Sourcery with this PR took 0.27 s vs 0.27 s on main (0% slower).
📖 Linting Swift with this PR took 0.42 s vs 0.42 s on main (0% slower).
📖 Linting VLC with this PR took 0.2 s vs 0.2 s on main (0% slower).
📖 Linting Wire with this PR took 1.75 s vs 1.77 s on main (1% faster).
📖 Linting WordPress with this PR took 0.93 s vs 0.96 s on main (3% faster).

Generated by 🚫 Danger

@imsonalbajaj imsonalbajaj reopened this Apr 25, 2025
SimplyDanny
SimplyDanny requested changes Jun 5, 2025
View reviewed changes
Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please see my comments below ...

SimplyDanny
SimplyDanny reviewed Jun 11, 2025
View reviewed changes
SimplyDanny
SimplyDanny approved these changes Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thanks!

The failing builds are not related to your changes. I need to spend some time on infrastructure updates. Afterwards I'll rebase your branch and merge it.

@SimplyDanny SimplyDanny force-pushed the main-6054-warning_actor_delegate_protocol branch from a43c4a3 to 8e17d66 Compare June 15, 2025 17:32
@SimplyDanny SimplyDanny enabled auto-merge (squash) June 15, 2025 17:40
@SimplyDanny SimplyDanny merged commit e2ef7ed into realm:main Jun 15, 2025
20 checks passed
@SimplyDanny SimplyDanny linked an issue Jul 24, 2025 that may be closed by this pull request
class_delegate_protocol warning triggered by the Actor protocol #6054
Closed
@SimplyDanny SimplyDanny mentioned this pull request Jul 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimplyDanny SimplyDanny SimplyDanny approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

class_delegate_protocol warning triggered by the Actor protocol

3 participants

@imsonalbajaj @SwiftLintBot @SimplyDanny