[UnusedDeclarationRule] Speed up and detect more dead code#3340
Merged
Conversation
By using SourceKit's `index` request to index the entire source file, we can avoid having to make `cursor-info` requests for every candidate token in the file, which scales linearly with the number of candiate tokens. For the Yams project, this approach improved the total SwiftLint run time by 4.6x: 7.9 down from 36.8s. The SourceKit index response doesn't have everything we need to identify declarations, so we still need to make some `cursor-info` requests, mostly to detect overrides: protocol conformances and parent class overrides. This approach ends up finding more unused declarations because the index contains more declared USRs than can be found by calling `cursor-info` on candidate tokens in a file.
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #3340 +/- ##
==========================================
- Coverage 90.58% 90.55% -0.04%
==========================================
Files 416 416
Lines 20406 20415 +9
==========================================
+ Hits 18484 18486 +2
- Misses 1922 1929 +7
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using SourceKit's
indexrequest to index the entire source file, we can avoid having to makecursor-inforequests for every candidate token in the file, which scales linearly with the number of candidate tokens.For the Yams project, this approach improved the total SwiftLint run time by 4.6x: 7.9 down from 36.8s.
The SourceKit index response doesn't have everything we need to identify declarations, so we still need to make some
cursor-inforequests, mostly to detect overrides: protocol conformances and parent class overrides.This approach ends up finding more unused declarations because the index contains more declared USRs than can be found by calling
cursor-infoon candidate tokens in a file.