Expose only TestHelpers and ExtraRulesTests as part of Bazel releases#6235
Merged
SimplyDanny merged 1 commit intomainfrom Sep 5, 2025
Merged
Expose only TestHelpers and ExtraRulesTests as part of Bazel releases#6235SimplyDanny merged 1 commit intomainfrom
TestHelpers and ExtraRulesTests as part of Bazel releases#6235SimplyDanny merged 1 commit intomainfrom
Conversation
Generated by 🚫 Danger |
896ad4b to
9a5a0af
Compare
jszumski
reviewed
Sep 5, 2025
| @@ -1,44 +1,15 @@ | |||
| load("@build_bazel_rules_swift//swift:swift.bzl", "swift_library", "swift_test") | |||
| load("//bazel:copts.bzl", "STRICT_COPTS", "TARGETED_COPTS") | |||
| load(":generated_tests.bzl", "generated_tests") | |||
Contributor
There was a problem hiding this comment.
I think this load will fail when given a release archive since it's excluded from release_files. I had to patch locally by adding the file:
def generated_tests():
pass
Collaborator
Author
There was a problem hiding this comment.
The idea is to stop exposing Tests/BUILD and with that all test sources. The only relevant test targets should be ExtraRulesTests and TestHelpers. This then also avoids that generated_tests.bzl is required. Is that reasonable?
Collaborator
Author
There was a problem hiding this comment.
If you like, you can try bazel.tar.gz which would be the archive for the next release.
Contributor
There was a problem hiding this comment.
Gotcha, I saw the analysis error on 0.60.0 but that linked archive looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other test targets don't need to be released.