This repository was archived by the owner on Apr 9, 2025. It is now read-only.
Don't disconnect html-page-context event from sphinx-tabs#318
Merged
Conversation
We are disconnecting the html-page-context event from sphinx-tabs, which was used to delete the static files from html files that didn't use sphinx-tabs. But in executablebooks/sphinx-tabs#198 this was changed to instead decide if the page should have the static files or not. Since we are removing that event, sphinx-tabs never gets to inject the static files, this breaks sphinx-tabs for projects using hoverxref. We no longer need to disconnect that signal, since we are overriding the html assets policy to `always`, which sphnx-tabs respects already executablebooks/sphinx-tabs#132 (more than 3 years ago).
Member
|
We need to include sphinx-tabs assets, CSS and JS, even if the page does not contain tabs. This is because the tooltip included in the page could contain a sphinx-tab inside. |
Member
Author
That's what this PR does. |
humitos
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are disconnecting the html-page-context event from sphinx-tabs, which was used to delete the static files from html files that didn't use sphinx-tabs. But in executablebooks/sphinx-tabs#198 this was changed to instead decide if the page should have the static files or not.
Since we are removing that event, sphinx-tabs never gets to inject the static files, this breaks sphinx-tabs for projects using hoverxref.
We no longer need to disconnect that signal, since we are overriding the html assets policy to
always, which sphnx-tabs respects already executablebooks/sphinx-tabs#132 (more than 3 years ago).📚 Documentation preview 📚: https://sphinx-hoverxref--318.org.readthedocs.build/en/318/