feat: tweaking our use of the no-use-before-define rule in TS#338
Merged
feat: tweaking our use of the no-use-before-define rule in TS#338
no-use-before-define rule in TS#338Conversation
erunion
commented
Mar 10, 2022
| // The stock `no-use-before-define` ESLint rule throws errors when TS interfaces, types, and | ||
| // enums are used before they're defined -- eventhough in TS that's OK. | ||
| 'no-use-before-define': 'off', | ||
| '@typescript-eslint/no-use-before-define': ['error'], |
Member
Author
There was a problem hiding this comment.
gratcliff
approved these changes
Mar 10, 2022
RyanGWU82
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
Slightly tweaks our
no-use-before-definerule usage in the TS config to allow TS types that can be used before they're defined without errors.For example, without this rule change the following code was throwing an error on
ConfigOptionsbeing used before it was defined even though TS is perfectly fine with where it's located in the file.: