Skip to content

Revert "fix: centering in firefox (#721)"#737

Merged
rafegoldberg merged 1 commit intonextfrom
revert/#721
Apr 13, 2023
Merged

Revert "fix: centering in firefox (#721)"#737
rafegoldberg merged 1 commit intonextfrom
revert/#721

Conversation

@rafegoldberg
Copy link
Copy Markdown
Contributor

@rafegoldberg rafegoldberg commented Apr 13, 2023 •
edited
Loading

📖 PR App

🧰 Changes

  • Revert #721, per my comment:

    @macuzi—You're quite right that "center" isn't technically a valid value for the [align] attribute, but we actually accept it within RDMD. The distinction between the two is that…

    • setting [align=middle] will align the image vertically to the center of the line's y axis.
    • setting [align=center] will force the image to be centered horizontally in it's container.

    These changes could possibly have some strange effects on how users image blocks are rendered, so unfortunately I think we have to revert this PR.

@rafegoldberg rafegoldberg merged commit 776bf7c into next Apr 13, 2023
@rafegoldberg rafegoldberg deleted the revert/#721 branch April 13, 2023 17:00
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2023 •
edited
Loading

A review app has been launched for this PR!

🔍 Inspect the app: https://dashboard.heroku.com/apps/markdown-pr-737

🧭 Take it for a spin: https://markdown-pr-737.herokuapp.com/

  • Shut down on Thu Apr 13: Since this PR is closed, its review app has been cleaned up. 🧽

@rafegoldberg
Copy link
Copy Markdown
Contributor Author

rafegoldberg commented Apr 14, 2023

This PR was released!

🚀 Changes included in v6.61.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macuzi macuzi Awaiting requested review from macuzi

@trishaprile trishaprile Awaiting requested review from trishaprile

1 more reviewer

@kellyjosephprice kellyjosephprice kellyjosephprice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rafegoldberg @kellyjosephprice