chore: removing remnants of the sonarjs plugin

erunion · erunion · commit 40b4694f0745 · 2022-01-03T16:17:32.000-08:00
diff --git a/index.js b/index.js
@@ -8,18 +8,10 @@ module.exports = {
     'plugin:import/errors',
     'plugin:import/warnings',
     'plugin:you-dont-need-lodash-underscore/compatible',
-    // 'plugin:sonarjs/recommended', // Temporarily disabling this rule until it gets ESLint 8 support
     'prettier',
     'prettier/prettier',
   ],
-  plugins: [
-    'eslint-comments',
-    'import',
-    'node',
-    'prettier',
-    // 'sonarjs',
-    'unicorn',
-  ],
+  plugins: ['eslint-comments', 'import', 'node', 'prettier', 'unicorn'],
   rules: {
     'arrow-body-style': 'off',
 
@@ -52,11 +44,6 @@ module.exports = {
 
     'prettier/prettier': ['error', prettierConfig],
 
-    // 'sonarjs/cognitive-complexity': 'off',
-    // 'sonarjs/no-collapsible-if': 'off',
-    // 'sonarjs/no-duplicate-string': 'off',
-    // 'sonarjs/no-duplicated-branches': 'off',
-
     'unicorn/catch-error-name': ['error', { ignore: ['^(error|err|e)$'] }],
     // "unicorn/consistent-function-scoping": "error", // Maybe?
     'unicorn/custom-error-definition': 'error',
diff --git a/testing.js b/testing.js
@@ -6,14 +6,7 @@ module.exports = {
     'plugin:jest-formatting/recommended',
     'plugin:testing-library/react',
   ],
-  plugins: [
-    'import',
-    'jest',
-    'jest-dom',
-    'node',
-    // 'sonarjs', // Temporarily disabling this rule until it gets ESLint 8 support
-    'testing-library',
-  ],
+  plugins: ['import', 'jest', 'jest-dom', 'node', 'testing-library'],
   env: {
     'jest/globals': true,
   },
@@ -36,7 +29,5 @@ module.exports = {
     // having a function be async and not return or await a Promise, we're only running this rule
     // for tests where such a case isn't likely to be a thing.
     'require-await': 'error',
-
-    // 'sonarjs/no-identical-functions': 'off',
   },
 };
