Refactor to use HTTP response reason phrases from response object #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we no longer have to maintain a list of HTTP reason phrases ourselves, but instead rely on those already present in our HTTP message abstraction.
WyriHaximus
approved these changes
Jul 4, 2017
jsor
reviewed
Jul 4, 2017
| $body->seek(0, SEEK_END); | ||
| $body->write(': ' . $reason); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Any particular reason you don't construct $message as before?
$message = 'Error ' . $code;
$reason = $response->getReasonPhrase();
if ($reason !== '') {
$message .= ': ' . $reason
}
Member
Author
There was a problem hiding this comment.
The $message is used only as a constructor parameter for the response body and the default reason phrase is only available after calling the constructor, hence this assignment.
kelunik
reviewed
Jul 4, 2017
| $reason = $response->getReasonPhrase(); | ||
| if ($reason !== '') { | ||
| $body = $response->getBody(); | ||
| $body->seek(0, SEEK_END); |
Member
Author
There was a problem hiding this comment.
This makes sure it seeks to the end so that we append the reason phrase to the existing body.
jsor
approved these changes
Jul 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we no longer have to maintain a list of HTTP reason phrases
ourselves, but instead rely on those already present in our HTTP message
abstraction.