Skip to content

Add logging in Exceptions.throwIf[Jvm]Fatal, add isFatal methods#3122

Merged
simonbasle merged 7 commits into3.4.xfrom
3111-logInThrowIfFatal
Aug 1, 2022
Merged

Add logging in Exceptions.throwIf[Jvm]Fatal, add isFatal methods#3122
simonbasle merged 7 commits into3.4.xfrom
3111-logInThrowIfFatal

Conversation

@simonbasle
Copy link
Copy Markdown
Contributor

This commit improves the discoverability of exceptions that are "fatal"
to Reactor by:

  • adding Exceptions.isFatal and Exceptions.isJvmFatal methods
  • adding logging to Exceptions.throwIfFatal and
    Exceptions.throwIfJvmFatal just before a fatal exception is thrown

This should at least help pinpointing such occurrences from the logs,
in cases where the thrown exception bubble all the way up the stack of
a thread with no uncaughtExceptionHandler for example.

Fixes #3111.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exceptions.throwIfFatal / throwIfJvmFatal should log fatal exceptions

4 participants