Initial translation of home page #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksenginew
commented
Jun 11, 2023
src/components/Layout/HomeContent.js
Outdated
Comment on lines
399
to
400
| ඔබේ සංවිධානයට වේදිකා සිලෝස් පාලම් කළ හැකි අතර, අවසානයේ සිට අවසානය | ||
| දක්වා සම්පූර්ණ විශේෂාංග හිමි කණ්ඩායම් සාදන්න. |
Author
There was a problem hiding this comment.
I don't sure whether this is correct
Collaborator
There was a problem hiding this comment.
Thank you @ksenginew for the PR .
wouldn't it be nice if we simplified it ? For example, let's keep the word "components" instead of saying "සංරචක"
I think it's more user friendly and understandable. What do you think?
Author
There was a problem hiding this comment.
oh, it would be better. I'll review this again.
Collaborator
There was a problem hiding this comment.
Yes I agree with @VihangaN We should not translate technical words, and guys please don't use inappropriate sinhala words, ( Singlish ).
Author
|
@VihangaN I think now this is ready to merge. |
Collaborator
Thanks @ksenginew |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #1 (comment) ...