Skip to content

Add function and class component#87

Merged
fjoshuajr merged 2 commits intoreactjs:masterfrom
klzns:add-function-component
Feb 12, 2019
Merged

Add function and class component#87
fjoshuajr merged 2 commits intoreactjs:masterfrom
klzns:add-function-component

Conversation

@klzns
Copy link
Copy Markdown
Contributor

@klzns klzns commented Feb 11, 2019

Following the changes made by the React team: reactjs/react.dev#863.

@klzns klzns changed the title Add function component Add function and class component Feb 11, 2019
@klzns klzns mentioned this pull request Feb 11, 2019
@fjoshuajr fjoshuajr added 📖 glossary | style-guide Definitions about terms in glossary and style-guide needs review A pull request ready to be reviewed labels Feb 11, 2019
Copy link
Copy Markdown
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klzns

LGTM 👍

@glaucia86 glaucia86 added the needs +1 Needs another approval before merging label Feb 12, 2019
Copy link
Copy Markdown
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@fjoshuajr fjoshuajr removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Feb 12, 2019
@fjoshuajr fjoshuajr merged commit 4901d6f into reactjs:master Feb 12, 2019
@klzns klzns deleted the add-function-component branch February 12, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📖 glossary | style-guide Definitions about terms in glossary and style-guide

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants