Skip to content

added hindi translation for js environment requirement #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
saranshkataria merged 5 commits into from
Oct 14, 2019
Merged

added hindi translation for js environment requirement #47

saranshkataria merged 5 commits into from
Oct 14, 2019

Conversation

@AlokTakshak
Copy link
Contributor

@AlokTakshak AlokTakshak commented Sep 25, 2019

No description provided.

@netlify
Copy link

netlify bot commented Sep 25, 2019 •
edited
Loading

Deploy preview for hi-reactjs ready!

Built with commit dafd432

https://deploy-preview-47--hi-reactjs.netlify.com

arshadkazmi42
arshadkazmi42 requested changes Sep 25, 2019
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some review.
Also you need to translate complete file in hindi.

Title links should go to the parent repository https://github.com/reactjs/reactjs.org

@AlokTakshak
Copy link
Contributor Author

AlokTakshak commented Sep 25, 2019

Added some review.
Also you need to translate complete file in hindi.

Title links should go to the parent repository https://github.com/reactjs/reactjs.org

can you tell me what i need to convert in hindi , and which title link should go to parent repo. I didn't get what needs to be modified

@arshadkazmi42
Copy link
Member

arshadkazmi42 commented Sep 26, 2019

Added some review.
Also you need to translate complete file in hindi.
Title links should go to the parent repository https://github.com/reactjs/reactjs.org

can you tell me what i need to convert in hindi , and which title link should go to parent repo. I didn't get what needs to be modified

All the text in the file should be translated to hindi. You can check this PR for reference
https://github.com/reactjs/hi.reactjs.org/pull/41/files

@AlokTakshak
Copy link
Contributor Author

AlokTakshak commented Sep 26, 2019

Added some review.
Also you need to translate complete file in hindi.
Title links should go to the parent repository https://github.com/reactjs/reactjs.org

can you tell me what i need to convert in hindi , and which title link should go to parent repo. I didn't get what needs to be modified

All the text in the file should be translated to hindi. You can check this PR for reference
https://github.com/reactjs/hi.reactjs.org/pull/41/files

English Words i have used are React, Map, Set, requestAnimationFrame, core-js, babel-pollyfill, pollyfill
The PR you mentioned is also using React, UI, React DOM , setInterval, ReactDOM.render(), Text, callback etc.
if you want i can change core-js, babel-pollyfill, pollyfill but rest are React and Javascript Specific.Please tell me what i need to change because i am not able to figure out of these word which i should change.

arshadkazmi42
arshadkazmi42 requested changes Sep 26, 2019
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have given few examples on how to translate.
Also I have not marked few of the lines which should be translated. You should look into other lines also, which I might not have marked.
Marked lines are for example.
Complete file needs to be translated in similar way.

Hope this helps to get you started.

arshadkazmi42
arshadkazmi42 requested changes Sep 26, 2019
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Add few reviews. Once those are handled, its good to go from my end.

arshadkazmi42
arshadkazmi42 approved these changes Sep 26, 2019
View reviewed changes
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯
Looks good to me.
For next steps @saranshkataria will be doing a second review and after that we will get this merged.
Thank you for all the awesome work you have done 🎉

@arshadkazmi42 arshadkazmi42 requested review from saranshkataria and removed request for arshadkazmi42 September 26, 2019 10:58
@tesseralis tesseralis mentioned this pull request Sep 26, 2019
Closed
88 tasks
saranshkataria
saranshkataria reviewed Oct 4, 2019
View reviewed changes
saranshkataria
saranshkataria reviewed Oct 4, 2019
View reviewed changes
@saranshkataria
Copy link
Member

saranshkataria commented Oct 4, 2019

Great work, added some comments and this is good to go once fixed!

@AlokTakshak
Copy link
Contributor Author

AlokTakshak commented Oct 9, 2019

Great work, added some comments and this is good to go once fixed!

Done

@saranshkataria
Copy link
Member

saranshkataria commented Oct 14, 2019

LGTM, Thank you!

@saranshkataria saranshkataria merged commit 3663cfc into reactjs:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saranshkataria saranshkataria saranshkataria left review comments

@arshadkazmi42 arshadkazmi42 arshadkazmi42 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlokTakshak @arshadkazmi42 @saranshkataria