fix(takeUntil): takeUntil should subscribe to the source if notifier synchronously completes without emitting#4039
Merged
benlesh merged 1 commit intoReactiveX:masterfrom Aug 27, 2018
Conversation
…sync completes without emitting This bug was introduced in ReactiveX#3504, which intended to not subscribe to the source if the notifier synchronously emits a value, but instead it only skipped subscribe if it completed
cartant
approved these changes
Aug 20, 2018
Collaborator
cartant
left a comment
There was a problem hiding this comment.
LGTM. In the docs, some notifiers - e.g. for delayWhen - are described as effecting a particular behaviour when the notifier completes, but that isn't the case for the takeUntil docs. They are explicit in stating that the notifier has to emit a value, so I think this fix should be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was introduced in #3504, which intended to not subscribe to the source if the notifier synchronously emits a value, but instead it only skipped subscribe if it completed
https://stackblitz.com/edit/js-j72dzx?file=index.js
Like most bugfixes this could potentially be a breaking change if someone is knowingly or unknowingly relying on this fact. Dunno what the current policy is on breaking bug fixes.