Skip to content

fix(testscheduler): type arguments to Observable creation functions#3928

Merged
benlesh merged 1 commit intoReactiveX:masterfrom
felixfbecker:typed-testscheduler
Jul 25, 2018
Merged

fix(testscheduler): type arguments to Observable creation functions#3928
benlesh merged 1 commit intoReactiveX:masterfrom
felixfbecker:typed-testscheduler

Conversation

@felixfbecker
Copy link
Copy Markdown
Contributor

Description:
Adds types to the arguments of TestScheduler createHot/ColdObservable to allow type inference.

Related issue (if exists):
Fixes #3921

@felixfbecker
Copy link
Copy Markdown
Contributor Author

Build failure is coming from master.

Copy link
Copy Markdown
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartant
Copy link
Copy Markdown
Collaborator

cartant commented Jul 17, 2018

@felixfbecker Yeah, the CI build is failing because of a linting error. See #3929.

@benlesh benlesh merged commit 0e30ef1 into ReactiveX:master Jul 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants