fix(subscribable): make subscribe() signature match Observable (#4050)

felixfbecker · benlesh · commit 865d8d70cb1b · 2018-08-27T11:07:00.000-07:00
* fix(subscribable): make subscribe() signature match Observable Fixes #3891 * test: cast string | number to string before concatenating T of this Observable is string | number, so TypeScript does not allow using +. The desired behaviour for this function is to concatenate the string values, so cast to strings. On master, these were incorrectly inferred as never, which is why this error was not surfaced. * test: correct type for selector function The hot() function will create an Observable that emits strings from marble diagrams (even if the strings contain numbers). So the type of x should be string, not number.
diff --git a/spec/operators/zipAll-spec.ts b/spec/operators/zipAll-spec.ts
@@ -39,7 +39,7 @@ describe('zipAll operator', () => {
       of('a', 'b', 'c'),
       of(1, 2, 3)
     )
-    .pipe(zipAll((a, b) => a + b))
+    .pipe(zipAll((a, b) => String(a) + String(b)))
     .subscribe((x) => {
       expect(x).to.equal(expected[i++]);
     }, null, done);
@@ -231,7 +231,7 @@ describe('zipAll operator', () => {
       const b = [4, 5, 6];
       const expected = '---x--#';
 
-      const selector = function (x: number, y: number) {
+      const selector = function (x: string, y: number) {
         if (y === 5) {
           throw new Error('too bad');
         } else {
@@ -378,7 +378,7 @@ describe('zipAll operator', () => {
       of('a', 'b', 'c'),
       of(1, 2)
     )
-    .pipe(zipAll((a, b) => a + b))
+    .pipe(zipAll((a, b) => String(a) + String(b)))
     .subscribe((x) => {
       expect(x).to.equal(expected[i++]);
     }, null, done);
diff --git a/src/internal/types.ts b/src/internal/types.ts
@@ -39,9 +39,8 @@ export type SubscribableOrPromise<T> = Subscribable<T> | Subscribable<never> | P
 /** OBSERVABLE INTERFACES */
 
 export interface Subscribable<T> {
-  subscribe(observerOrNext?: PartialObserver<T> | ((value: T) => void),
-            error?: (error: any) => void,
-            complete?: () => void): Unsubscribable;
+  subscribe(observer?: PartialObserver<T>): Unsubscribable;
+  subscribe(next?: (value: T) => void, error?: (error: any) => void, complete?: () => void): Unsubscribable;
 }
 
 export type ObservableInput<T> = SubscribableOrPromise<T> | ArrayLike<T> | Iterable<T>;
