Add ability to provide custom ExceptionFactory #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Sorry for taking so long to get to this. If you can please rebase this, I'll get it merged. |
Contributor
Author
|
@clairernovotny |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fixes #844, fixes #882, fixes #272, fixes #562
What is the current behavior?
Refit throws exception if response status is not successful. No (easy) way to override that behavior.
What is the new behavior?
Add property to RefitSettings:
public Func<HttpResponseMessage, Task<Exception>> ExceptionFactory { get; set; }Throw exception created by this Func. If it returns null - do not throw anything.
Also, added overload to
ApiException.Createmethod to allow to provide custom exception message.Please check if the PR fulfills these requirements
Other information:
Open question: I wanted to allow to create custom exceptions (i.e. non
ApiException), however that leads to issue when Api method returnsApiResponse. It has propertyApiException Error { get; }, and I cannot put custom Exception type there. Currently I simply ignore exception, if it is not ApiException.Not sure whether there is a better way.