Skip to content

feat: added larger benchmark #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChrisPulman merged 2 commits into from
Sep 29, 2024
Merged

feat: added larger benchmark #1848

ChrisPulman merged 2 commits into from
Sep 29, 2024

Conversation

@TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Sep 27, 2024 •
edited
Loading

  • Added benchmark for larger projects (SmallInterface copied 100 times).
  • Moved the project text to a dedicated class.
  • Kept it "small" so benchmarks will run under 2 minutes.

Benchmarks

Method Mean Error StdDev Gen0 Gen1 Allocated
Compile 250.0 us 2.03 us 1.80 us 12.6953 2.9297 117.52 KB
Cached 217.7 us 3.63 us 4.04 us 12.2070 2.9297 114.87 KB
CompileMany 8,920.5 us 36.61 us 34.24 us 687.5000 343.7500 6354.55 KB
CachedMany 7,919.1 us 57.02 us 47.61 us 671.8750 328.1250 6289.47 KB

#1791

@TimothyMakkison TimothyMakkison marked this pull request as ready for review September 27, 2024 20:44
@codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.79%. Comparing base (6ebeda5) to head (15ded9e).
Report is 113 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1848      +/-   ##
==========================================
- Coverage   87.73%   83.79%   -3.94%     
==========================================
  Files          33       36       +3     
  Lines        2348     2456     +108     
  Branches      294      346      +52     
==========================================
- Hits         2060     2058       -2     
- Misses        208      316     +108     
- Partials       80       82       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisPulman ChrisPulman enabled auto-merge (squash) September 29, 2024 01:26
@ChrisPulman ChrisPulman merged commit 27b436c into reactiveui:main Sep 29, 2024
@github-actions
Copy link

github-actions bot commented Oct 14, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ChrisPulman ChrisPulman ChrisPulman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyMakkison @ChrisPulman