Skip to content

Rethrow for Better Stack Trace #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anaisbetts merged 3 commits into from
Jul 7, 2023
Merged

Rethrow for Better Stack Trace #1532

anaisbetts merged 3 commits into from
Jul 7, 2023

Conversation

@dahlbyk
Copy link
Contributor

@dahlbyk dahlbyk commented Jul 5, 2023

What kind of change does this PR introduce?
Enhancement

What is the current behavior?
ApiException call stack starts with something like:

   at Refit.RequestBuilderImplementation.<>c__DisplayClass14_0`2.<<BuildCancellableTaskFuncForMethod>b__0>d.MoveNext()

What is the new behavior?
ApiException call stack starts with something like:

   at Refit.Implementation.Generated.RefitTestsIGitHubApi.<global::Refit-Tests-IGitHubApi-CreateUser>d__29.MoveNext()

Useful for observability to know which request method failed.

What might this PR break?
Folks that depend on the existing stack trace.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
👋

@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (4744780) 90.08% compared to head (817fbfa) 90.08%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1532   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files          33       33           
  Lines        1685     1685           
=======================================
  Hits         1518     1518           
  Misses        167      167

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anaisbetts
Copy link
Member

anaisbetts commented Jul 5, 2023

Seems legit but what's with all of these whitespace changes?

@dahlbyk
Copy link
Contributor Author

dahlbyk commented Jul 5, 2023

Seems legit but what's with all of these whitespace changes?

I knew you'd ask. I can drop the first commit, autoformat was just annoying me so I got them out of the way. The second commit seems useful?

@dahlbyk
Copy link
Contributor Author

dahlbyk commented Jul 5, 2023 •
edited
Loading

I can drop the first commit

Done

The second commit seems useful?

I kept trimming a trailing space but reverted the rest.

@dahlbyk

This comment was marked as outdated.

Sign in to view
@anaisbetts anaisbetts merged commit 6a16c08 into reactiveui:main Jul 7, 2023
@anaisbetts
Copy link
Member

anaisbetts commented Jul 7, 2023

✨

@dahlbyk dahlbyk deleted the rethrow branch July 7, 2023 18:02
@github-actions
Copy link

github-actions bot commented Jul 22, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dahlbyk @anaisbetts