feat: rewrite drawer for a new RNGH API by osdnk · Pull Request #11776 · react-navigation/react-navigation

osdnk · 2024-01-09T23:08:25Z

This PR moves the drawer to the new API.

Screen.Recording.2024-02-11.at.20.45.55.mov

packages/drawer/src/index.tsx

codecov-commenter · 2024-01-09T23:09:56Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.25%. Comparing base (7ed2bc1) to head (a37459a).
Report is 198 commits behind head on main.

Files with missing lines	Patch %	Lines
...t-native-drawer-layout/src/views/Drawer.native.tsx	26.66%	11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11776      +/-   ##
==========================================
+ Coverage   77.23%   77.25%   +0.01%     
==========================================
  Files         211      209       -2     
  Lines        6317     6313       -4     
  Branches     2495     2496       +1     
==========================================
- Hits         4879     4877       -2     
+ Misses       1384     1382       -2     
  Partials       54       54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-01-09T23:10:03Z

The Expo app for the example from this branch is ready!

https://expo.dev/@react-navigation/react-navigation-example?serviceType=eas&distribution=expo-go&scheme=exp+react-navigation-example&channel=pr-11776&sdkVersion=49.0.0

netlify · 2024-01-09T23:10:21Z

✅ Deploy Preview for react-navigation-example ready!

Name	Link
🔨 Latest commit	`82a1f8e`
🔍 Latest deploy log	https://app.netlify.com/sites/react-navigation-example/deploys/659dd1eb11d3980008ffc143
😎 Deploy Preview	https://deploy-preview-11776--react-navigation-example.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-01-09T23:11:53Z

✅ Deploy Preview for react-navigation-example ready!

Name	Link
🔨 Latest commit	`a37459a`
🔍 Latest deploy log	https://app.netlify.com/sites/react-navigation-example/deploys/660135d64afd4600084d09e7
😎 Deploy Preview	https://deploy-preview-11776--react-navigation-example.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…rngh-drawer

packages/react-native-drawer-layout/src/views/Drawer.tsx

packages/react-native-drawer-layout/src/views/GestureHandler.tsx

packages/react-native-drawer-layout/src/views/Drawer.tsx

github-actions · 2024-02-11T18:52:46Z

The Expo app for the example from this branch is ready!

https://expo.dev/@react-navigation/react-navigation-example?serviceType=eas&distribution=expo-go&scheme=exp+react-navigation-example&channel=pr-11776&sdkVersion=50.0.0

…t-navigation into @osdnk/rngh-drawer

packages/react-native-drawer-layout/src/views/Drawer.tsx

satya164 · 2024-03-17T13:36:39Z

I found an issue. When the drawer is on the right and I close it via gesture, it doesn't close fullly.

Kapture.2024-03-17.at.14.35.28.mp4

osdnk · 2024-03-23T22:21:45Z

@satya164 I addressed the problem

osdnk added 2 commits January 10, 2024 01:07

feat: rewrite drawer for a new RNGH API

82a1f8e

Merge branch 'main' into @osdnk/rngh-drawer

ba434bf

osdnk marked this pull request as draft January 9, 2024 23:08

osdnk commented Jan 9, 2024

View reviewed changes

packages/drawer/src/index.tsx Show resolved Hide resolved

osdnk added 2 commits January 10, 2024 01:35

feat: rewrite drawer for a new RNGH API etc

fcbf10d

Merge remote-tracking branch 'origin/@osdnk/rngh-drawer' into @osdnk/…

4a7e48e

…rngh-drawer

satya164 requested changes Jan 10, 2024

View reviewed changes

satya164 force-pushed the main branch from 94e4ace to 9986736 Compare January 10, 2024 17:40

fix: better types

f6d5f35

satya164 reviewed Jan 11, 2024

View reviewed changes

packages/react-native-drawer-layout/src/views/GestureHandler.tsx Outdated Show resolved Hide resolved

osdnk added 5 commits January 12, 2024 01:04

fix: types

43e29ab

fix: polishes

217b612

fix: remove leftovers

a310148

fix: different types

e1dfa99

fix: br

36cf247

osdnk commented Jan 11, 2024

View reviewed changes

packages/react-native-drawer-layout/src/views/Drawer.tsx Outdated Show resolved Hide resolved

fix: inline the type for GestureDetector

1cb70e0

satya164 force-pushed the @osdnk/rngh-drawer branch from f7faa22 to 1cb70e0 Compare January 12, 2024 00:15

satya164 mentioned this pull request Jan 18, 2024

[Drawer] refactor: use GestrueDetector to fix onStart bug #10928

Closed

Merge branch 'main' into @osdnk/rngh-drawer

5945e41

osdnk marked this pull request as ready for review February 11, 2024 18:51

osdnk added 2 commits February 11, 2024 21:17

fix: callback

6a4d0a1

Merge branch '@osdnk/rngh-drawer' of github.com:react-navigation/reac…

4ef908a

…t-navigation into @osdnk/rngh-drawer

satya164 reviewed Feb 23, 2024

View reviewed changes

packages/react-native-drawer-layout/src/views/Drawer.tsx Outdated Show resolved Hide resolved

packages/react-native-drawer-layout/src/views/Drawer.tsx Outdated Show resolved Hide resolved

fix: use callback instead of explicit config

716f7b1

osdnk and others added 2 commits March 17, 2024 14:21

Merge branch 'main' into @osdnk/rngh-drawer

85d0ced

Merge branch 'main' into @osdnk/rngh-drawer

f94db15

osdnk added 2 commits March 23, 2024 22:11

Merge branch 'main' into @osdnk/rngh-drawer

4812b1f

fix: track gesture state properly

bce41da

refactor: remove duplicate assignment

a37459a

satya164 approved these changes Mar 25, 2024

View reviewed changes

satya164 enabled auto-merge (squash) March 25, 2024 08:29

satya164 merged commit 5d7d81e into main Mar 25, 2024

satya164 deleted the @osdnk/rngh-drawer branch March 25, 2024 08:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: rewrite drawer for a new RNGH API#11776

feat: rewrite drawer for a new RNGH API#11776
satya164 merged 20 commits intomainfrom
@osdnk/rngh-drawer

osdnk commented Jan 9, 2024 •

edited

Loading

Uh oh!

Uh oh!

codecov-commenter commented Jan 9, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

netlify bot commented Jan 9, 2024

Uh oh!

netlify bot commented Jan 9, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2024

Uh oh!

Uh oh!

Uh oh!

satya164 commented Mar 17, 2024

Uh oh!

osdnk commented Mar 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

osdnk commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 9, 2024

Uh oh!

netlify bot commented Jan 9, 2024

✅ Deploy Preview for react-navigation-example ready!

Uh oh!

netlify bot commented Jan 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for react-navigation-example ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2024

Uh oh!

Uh oh!

Uh oh!

satya164 commented Mar 17, 2024

Uh oh!

osdnk commented Mar 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

osdnk commented Jan 9, 2024 •

edited

Loading

codecov-commenter commented Jan 9, 2024 •

edited

Loading

netlify bot commented Jan 9, 2024 •

edited

Loading