refactor!: drop independent prop in favor of a wrapper component#10907
Merged
satya164 merged 1 commit into@satya164/navigation-in-childfrom Oct 11, 2022
Merged
Conversation
|
The Expo app for the example from this branch is ready! expo.dev/@react-navigation/react-navigation-example?release-channel=pr-10907 |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## @satya164/navigation-in-child #10907 +/- ##
=================================================================
+ Coverage 75.27% 75.29% +0.02%
=================================================================
Files 168 171 +3
Lines 5173 5178 +5
Branches 2005 2004 -1
=================================================================
+ Hits 3894 3899 +5
Misses 1239 1239
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kacperkapusciak
approved these changes
Oct 7, 2022
cdc8f11 to
6fa3de4
Compare
82aac40 to
24ceac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops the
independentprop from the container in favor of a component. In case of cases such as mini-apps, this allows the parent app to disconnect the child navigation tree from itself.Another reason is that a lot of newbies added
independentprop to avoid error and got confused when nested navigation didn't work. By moving it into a component and making it harder to do it accidentally, maybe this can be avoided.