Current Behavior
While using Navigation the Header height for Iphone X is rendered opposite as it should be when changing orientation (n.b. initial render is correct), e.g. with top padding for landscape and slim for portrait.
Initial Render
Landscape
Portait
Expected Behavior
In landscape the Header should be default header height.
In Portrait for Iphone X - It requires top padding to avoid notch area (... safe area).
Behaviour is consistent in RN v.59.4
How to reproduce
You can see the window and screen dimensions logic returned from native have been changed. It seems to return the window the same regardless of orientation.
Your Environment
| software |
version |
| react-navigation |
^2.18.3 (also tried with v3.x) |
| react-native |
.59.5 |
FYI - I've cross posted a link to this in the commit discussion. react/react-native#19932 (comment)
Current Behavior
While using Navigation the Header height for Iphone X is rendered opposite as it should be when changing orientation (n.b. initial render is correct), e.g. with top padding for landscape and slim for portrait.
Initial Render
Landscape
Portait
Expected Behavior
In landscape the Header should be default header height.
In Portrait for Iphone X - It requires top padding to avoid notch area (... safe area).
Behaviour is consistent in RN v.59.4
How to reproduce
Install RN v.59.5-10
Review RN commit - react/react-native@72b4cc0
[iOS] [Fixed] - Pass back correct dimensions for application window in Dimensions module
You can see the window and screen dimensions logic returned from native have been changed. It seems to return the window the same regardless of orientation.
Your Environment
FYI - I've cross posted a link to this in the commit discussion. react/react-native#19932 (comment)