v1.0.0-beta 2 #838
Merged
v1.0.0-beta 2 #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
==========================================
+ Coverage 53.03% 55.88% +2.84%
==========================================
Files 29 32 +3
Lines 511 578 +67
Branches 109 114 +5
==========================================
+ Hits 271 323 +52
- Misses 184 201 +17
+ Partials 56 54 -2
Continue to review full report at Codecov.
|
* Pass activeOpacity to TouchableOpacity inside Tile * Update Tile tests
Fix error on empty rightTitle prop by adding !!
* feat(theming): Remove not-used colors * feat(theme): Add primary color and use through components Added in button, button group, badge, and header * Update snapshots * Update underColor on buttonGroup to match selectedColor * Snapshots * Add color for Checkbox
* Add ButtonComponent props * Use `linearGradientProps` + add error on mounting
* Add SearchBar wrapper * Split SearchBar iOS and Android into separate files * Add back default SearchBar * Update root import * Add back Input right/left icon * Rename loadingIcon to loadingProps * Specify `platform` PropType * Add a fallback * Move tests to `searchbar` * Remove old Search component * Fix loading props spreading overriding whole style * Remove useless things * Add tests for SearchBar * Generate snapshots * Add more tests * Update tests * Update documentation * Fix typo
Made tests pass
xavier-villelegier
approved these changes
Jan 28, 2018
Collaborator
xavier-villelegier
left a comment
There was a problem hiding this comment.
HELL YEAH 🔥 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: https://github.com/react-native-training/react-native-elements/releases/tag/untagged-bdfe1f8e69fdf8ed60f5