Skip to content

fix: SpeedDial component cant work in web platform #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 3 commits into from
Jan 29, 2024
Merged

fix: SpeedDial component cant work in web platform #3880

arpitBhalla merged 3 commits into from
Jan 29, 2024

Conversation

@alwaysloseall
Copy link
Contributor

@alwaysloseall alwaysloseall commented Jan 18, 2024

Motivation

Fixes # (issue)

#3879

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@codecov
Copy link

codecov bot commented Jan 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c87b7ec) 79.70% compared to head (52847e1) 79.70%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3880   +/-   ##
=======================================
  Coverage   79.70%   79.70%           
=======================================
  Files          87       87           
  Lines        1843     1843           
  Branches      819      820    +1     
=======================================
  Hits         1469     1469           
  Misses        369      369           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khushal87
Copy link
Member

khushal87 commented Jan 20, 2024

Hey @alwaysloseall, please fix the linting issues and commit. Thanks 😄

@arpitBhalla arpitBhalla merged commit 548e6d3 into react-native-elements:next Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khushal87 khushal87 khushal87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alwaysloseall @khushal87 @arpitBhalla