fix(base,example): Dialog.title not honoring theme in dark mode. #3878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates Dialog Title theme honoring and adds Testing for Dialog Title Updates clean command to use rimraf Give some love to Dialog example component(fix checkbox example in dark mode) Issue: react-native-elements#3876
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3878 +/- ##
==========================================
+ Coverage 79.69% 79.70% +0.01%
==========================================
Files 87 87
Lines 1842 1843 +1
Branches 818 819 +1
==========================================
+ Hits 1468 1469 +1
Misses 369 369
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Member
|
Hey @amutsch, please fix the linting issues and commit the changes. Thanks 😄 |
Author
|
Thanks for the review @khushal87 , not sure how I missed that on the tests., updated now |
khushal87
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Dialog Title theme honoring and adds Testing for Dialog Title Updates clean command to use rimraf
Give some love to Dialog example component(fix checkbox example in dark mode)
Issue: #3876
Motivation
Dialog.Title was not honoring the theming of the library
Fixes # (issue)
Type of change
How Has This Been Tested?
Was tested in my locale dev app using RNE libs, tested in example app, new JUnit tests introduced to verify and ensure it doesn't break again.
Basic setup of light mode and dark mode. Flip to dark mode and it will not change the text to white.
exampleappChecklist
yarn docs-build-apiAdditional context
Base Dialog.Title component was leveraging the react-native text component and there was no chance for the theme to be honored. The Theme was also not being propogated properly.