Skip to content

fix: update themed package version to latest #3871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
khushal87 merged 1 commit into from
Dec 27, 2023
Merged

fix: update themed package version to latest #3871

khushal87 merged 1 commit into from
Dec 27, 2023

Conversation

@khushal87
Copy link
Member

@khushal87 khushal87 commented Dec 27, 2023 •
edited
Loading

Motivation

Fixes #3829

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@khushal87 khushal87 merged commit a3e52ad into react-native-elements:next Dec 27, 2023
@codecov
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (553791d) 79.69% compared to head (bed3f41) 79.69%.
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3871   +/-   ##
=======================================
  Coverage   79.69%   79.69%           
=======================================
  Files          87       87           
  Lines        1842     1842           
  Branches      818      818           
=======================================
  Hits         1468     1468           
  Misses        369      369           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramijarrar
Copy link

ramijarrar commented May 8, 2024 •
edited
Loading

Hi @khushal87 / @arpitBhalla - any chance we could get a new RC soon which includes this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dependencies are not updated

2 participants

@khushal87 @ramijarrar