fix(SearchBar): fixed iOS search bar icons issue #3865
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3865 +/- ##
=======================================
Coverage 79.69% 79.69%
=======================================
Files 87 87
Lines 1842 1842
Branches 818 818
=======================================
Hits 1468 1468
Misses 369 369
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
Hey @JaweedVenturedive what's the vector icon package version for which you are facing the issue? I was not able to reproduce the issue on my iOS device. |
Hello, @khushal87 I can re-produce the issue on vector icon package version 10.0.2. |
Using the same version and not been able to reproduce it on our sample app
|
@khushal87 Let me re-check again. |
|
@khushal87 I can re-produce the issue on both android and iOS devices. |
|
My assumption is something is wrong with my setup. Regardless from the issue comments I interpret that it is a genuine issue. Therefore merging it. Thanks for your contributions. 😄 |
|
@khushal87 Thank you so much for your response |
Motivation
On Search Bar when passing "ios" to platform prop the icon shows question mark '?' symbol, which shows icon is not available and throws warning. Fixed this issue by modifying the SearchBar.ios.tsx by providing proper and available props for name property when displaying icons.
Fixes #3837
Type of change
How Has This Been Tested?
exampleappChecklist
Additional context
Before Fix
After Fix