Skip to content

Conversation

@flysteur-dev
Copy link
Contributor

@flysteur-dev flysteur-dev commented Sep 8, 2023

Motivation

Rating component have missing props causing impossibility to customize it.
AirbnbRating is not affected.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

20230909_002129

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for react-native-elements ready!

Name Link
🔨 Latest commit 796acf5
🔍 Latest deploy log https://app.netlify.com/sites/react-native-elements/deploys/64fc38e9416be60008a4a984
😎 Deploy Preview https://deploy-preview-3838--react-native-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arpitBhalla arpitBhalla merged commit 1a983ff into react-native-elements:next Sep 9, 2023
@naviniitk
Copy link

Hi, I was using Rating component in my app but it was not working as the props are not being passed. I found this PR and it is merged. where can I get these changes. I am using 4.0.0-rc.8 version. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants