Skip to content

docs: add avatar component changes in the migration guide #3805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 1 commit into from
Jun 16, 2023
Merged

docs: add avatar component changes in the migration guide #3805

arpitBhalla merged 1 commit into from
Jun 16, 2023

Conversation

@khushal87
Copy link
Member

@khushal87 khushal87 commented Jun 10, 2023 •
edited
Loading

Motivation

Added migration guide for the Avatar component changes as per - #3760 (comment)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@netlify
Copy link

netlify bot commented Jun 10, 2023 •
edited
Loading

✅ Deploy Preview for react-native-elements ready!

Name Link
🔨 Latest commit 2f5b699
🔍 Latest deploy log https://app.netlify.com/sites/react-native-elements/deploys/64845480b7aca90008807c02
😎 Deploy Preview https://deploy-preview-3805--react-native-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@khushal87 khushal87 requested a review from arpitBhalla June 10, 2023 10:46
@khushal87
Copy link
Member Author

khushal87 commented Jun 10, 2023

@arpitBhalla

This has to be fixed imo:

4:16:24 PM: ---------------------------------------------------------------------
  UNSUPPORTED BUILD IMAGE

  The build image for this site uses Ubuntu 16.04 Xenial Xerus, which is no longer supported.

  To enable builds for this site, select a later build image at the following link:
  https://app.netlify.com/sites/react-native-elements-docs/settings/deploys#build-image-selection

  For more details, visit the build migration guide:
  https://answers.netlify.com/t/please-read-end-of-support-for-xenial-build-image-everything-you-need-to-know/68239
  ---------------------------------------------------------------------

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #3805 (f467375) into next (5a48d33) will not change coverage.
The diff coverage is n/a.

❗ Current head f467375 differs from pull request most recent head 2f5b699. Consider uploading reports for the commit 2f5b699 to get more accurate results

@@           Coverage Diff           @@
##             next    #3805   +/-   ##
=======================================
  Coverage   79.85%   79.85%           
=======================================
  Files          87       87           
  Lines        1822     1822           
  Branches      804      804           
=======================================
  Hits         1455     1455           
  Misses        362      362           
  Partials        5        5

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla merged commit 781f939 into react-native-elements:next Jun 16, 2023
@aleantoniolli
Copy link

aleantoniolli commented Oct 2, 2023 •
edited
Loading

I can't use no more the props "title" and "icon" as a placeholder for "source". Is this on purpose?

For example, the documentation explain:

"icon" Avatar prop description:

Displays an icon as the main content of the Avatar. Cannot be used alongside title. When used with the source prop it will be used as the placeholder.

When I use both the container is divided at two parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arpitBhalla arpitBhalla Awaiting requested review from arpitBhalla

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khushal87 @aleantoniolli @arpitBhalla