Skip to content

feat(Header): add hideStatusBar prop in header (#3755) #3801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 3 commits into from
Jun 7, 2023
Merged

feat(Header): add hideStatusBar prop in header (#3755) #3801

arpitBhalla merged 3 commits into from
Jun 7, 2023

Conversation

@ramizqazi
Copy link
Contributor

@ramizqazi ramizqazi commented May 30, 2023 •
edited
Loading

Motivation

Fixes issue #3755

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

None

@netlify
Copy link

netlify bot commented May 30, 2023 •
edited
Loading

✅ Deploy Preview for react-native-elements ready!

Name Link
🔨 Latest commit 9298abc
🔍 Latest deploy log https://app.netlify.com/sites/react-native-elements/deploys/64802d1f1a63ae00084ffdc1
😎 Deploy Preview https://deploy-preview-3801--react-native-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #3801 (7c5ce9d) into next (6ea6a97) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 7c5ce9d differs from pull request most recent head 9298abc. Consider uploading reports for the commit 9298abc to get more accurate results

@@            Coverage Diff             @@
##             next    #3801      +/-   ##
==========================================
+ Coverage   79.39%   79.42%   +0.03%     
==========================================
  Files          87       87              
  Lines        1820     1823       +3     
  Branches      810      814       +4     
==========================================
+ Hits         1445     1448       +3     
  Misses        370      370              
  Partials        5        5
Impacted Files Coverage Δ
packages/base/src/Header/Header.tsx 96.55% <100.00%> (+0.39%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla merged commit 1ddc630 into react-native-elements:next Jun 7, 2023
@arpitBhalla arpitBhalla linked an issue Jun 18, 2023 that may be closed by this pull request
Add ability to remove StatusBar from Header #3755
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ability to remove StatusBar from Header

2 participants

@ramizqazi @arpitBhalla