Skip to content

fix(Icon): add testID prop #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 2 commits into from
Jun 7, 2023
Merged

fix(Icon): add testID prop #3787

arpitBhalla merged 2 commits into from
Jun 7, 2023

Conversation

@KrisLau
Copy link
Contributor

@KrisLau KrisLau commented May 11, 2023 •
edited
Loading

Motivation

Fixes #3786 (no clue how to do it for speed dial action)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

N/A

@netlify
Copy link

netlify bot commented May 11, 2023 •
edited
Loading

✅ Deploy Preview for react-native-elements ready!

Name Link
🔨 Latest commit 396500d
🔍 Latest deploy log https://app.netlify.com/sites/react-native-elements/deploys/64802e81dda374000823c27f
😎 Deploy Preview https://deploy-preview-3787--react-native-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@arpitBhalla arpitBhalla changed the title Add overwritable testID to Icon fix(Icon): add testID prop May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Merging #3787 (c525278) into next (dbb66c6) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head c525278 differs from pull request most recent head 396500d. Consider uploading reports for the commit 396500d to get more accurate results

@@            Coverage Diff             @@
##             next    #3787      +/-   ##
==========================================
- Coverage   79.42%   79.40%   -0.03%     
==========================================
  Files          87       87              
  Lines        1818     1821       +3     
  Branches      801      812      +11     
==========================================
+ Hits         1444     1446       +2     
- Misses        369      370       +1     
  Partials        5        5
Impacted Files Coverage Δ
packages/base/src/Icon/Icon.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla merged commit a13b22b into react-native-elements:next Jun 7, 2023
@theianmay theianmay self-assigned this Jan 5, 2026
@theianmay theianmay mentioned this pull request Jan 5, 2026
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@theianmay theianmay

Labels

PR: Bug Fix 🐛

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Components missing testID prop

3 participants

@KrisLau @theianmay @arpitBhalla