Skip to content

docs: customisation page snippet #3614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arpitBhalla merged 2 commits into from
Aug 17, 2022
Merged

docs: customisation page snippet #3614

arpitBhalla merged 2 commits into from
Aug 17, 2022

Conversation

@rvenky125
Copy link
Contributor

@rvenky125 rvenky125 commented Aug 15, 2022 •
edited
Loading

You were used to Props instead of Params. Thank you

Motivation

Fixes # (issue)

There used a name that was different from its declaration.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Jest Unit Test
  • Checked with example app

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation using yarn docs-build-api
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

rvenky125 and others added 2 commits August 15, 2022 15:43
@rvenky125
There need small naming changes in 212, 220
442c0e5 
You were used to Props instead of Params. Thank you
@arpitBhalla
Update 0.index.mdx
69660a9
@arpitBhalla arpitBhalla changed the title There need small naming changes in 212, 220 docs: customisation page snippet Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #3614 (20bce95) into next (d6e6b3f) will not change coverage.
The diff coverage is n/a.

❗ Current head 20bce95 differs from pull request most recent head 69660a9. Consider uploading reports for the commit 69660a9 to get more accurate results

@@           Coverage Diff           @@
##             next    #3614   +/-   ##
=======================================
  Coverage   79.38%   79.38%           
=======================================
  Files          87       87           
  Lines        1809     1809           
  Branches      801      801           
=======================================
  Hits         1436     1436           
  Misses        367      367           
  Partials        6        6

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arpitBhalla arpitBhalla merged commit cc9ae83 into react-native-elements:next Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Docs 📝

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rvenky125 @arpitBhalla