Skip to content

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Aug 9, 2021

What kind of change does this PR introduce?
Migrate existing tests from enzyme to react native testing library

  • BottomSheet
  • Input
  • SearchBar
  • CheckBox

Did you add tests for your changes?
yes i have added few more test case as well.

If relevant, did you update the documentation?
Not required

Summary
Existing code uses enzyme for testing this PR would change it to react native testing library.
Related #2922

Does this PR introduce a breaking change?
No

Other information
GSoC task of @arpitBhalla

arpitBhalla and others added 8 commits July 18, 2021 18:57
Co-authored-by: Arpit Bhalla <68342121+arpit-bhalla@users.noreply.github.com>
Co-authored-by: Arpit Bhalla <68342121+arpit-bhalla@users.noreply.github.com>
Co-authored-by: Arpit Bhalla <68342121+arpit-bhalla@users.noreply.github.com>
Co-authored-by: Arpit Bhalla <68342121+arpit-bhalla@users.noreply.github.com>
Co-authored-by: Arpit Bhalla <68342121+arpit-bhalla@users.noreply.github.com>
Co-authored-by: Arpit Bhalla <68342121+arpit-bhalla@users.noreply.github.com>
Co-authored-by: Arpit Bhalla <68342121+arpit-bhalla@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Aug 9, 2021

✔️ Deploy Preview for react-native-elements canceled.

🔨 Explore the source changes: e62528c

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native-elements/deploys/61114fc3274df3000745c7b4

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #3169 (e62528c) into next (71bb8a2) will decrease coverage by 2.96%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #3169      +/-   ##
==========================================
- Coverage   83.92%   80.96%   -2.97%     
==========================================
  Files          78       78              
  Lines        1692     1681      -11     
  Branches      678      678              
==========================================
- Hits         1420     1361      -59     
- Misses        267      315      +48     
  Partials        5        5              
Impacted Files Coverage Δ
src/CheckBox/CheckBox.tsx 93.54% <ø> (-6.46%) ⬇️
src/CheckBox/components/CheckBoxIcon.tsx 100.00% <ø> (+16.66%) ⬆️
src/Input/Input.tsx 64.86% <ø> (-35.14%) ⬇️
src/SearchBar/SearchBar-android.tsx 77.96% <ø> (-20.34%) ⬇️
src/SearchBar/SearchBar-default.tsx 80.85% <ø> (-14.90%) ⬇️
src/config/withTheme.tsx 87.09% <ø> (ø)
src/SearchBar/SearchBar-ios.tsx 70.58% <100.00%> (-19.12%) ⬇️
src/SearchBar/__tests__/common.tsx 100.00% <100.00%> (ø)
src/SearchBar/SearchBar.tsx 73.33% <0.00%> (-26.67%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71bb8a2...e62528c. Read the comment docs.

@flyingcircle flyingcircle merged commit 9714237 into react-native-elements:next Aug 10, 2021
@arpitBhalla arpitBhalla deleted the rn-testing3 branch August 10, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants