Migrate Tests to React Native Testing library #3150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Arpit Bhalla <68342121+arpit-bhalla@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## next #3150 +/- ##
==========================================
+ Coverage 83.87% 84.09% +0.21%
==========================================
Files 78 78
Lines 1687 1685 -2
Branches 666 666
==========================================
+ Hits 1415 1417 +2
+ Misses 268 264 -4
Partials 4 4
Continue to review full report at Codecov.
|
Co-authored-by: Arpit Bhalla <68342121+arpit-bhalla@users.noreply.github.com>
Co-authored-by: Arpit Bhalla <68342121+arpit-bhalla@users.noreply.github.com>
Merged
18 tasks
flyingcircle
requested changes
Aug 9, 2021
Collaborator
There was a problem hiding this comment.
I don't think code in .ci is th right place. You want to use setupFiles in the jest config instead: https://stackoverflow.com/questions/50411719/shared-utils-functions-for-testing-with-jest/52910794
EDIT: actually thinking about it a bit more. It's really doesn't matter too much. I think this all looks fine.
flyingcircle
approved these changes
Aug 9, 2021
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Migrate existing tests from enzyme to react native testing library
Did you add tests for your changes?
yes i have added few more test case as well.
If relevant, did you update the documentation?
Not required
Summary
Existing code uses enzyme for testing this PR would change it to react native testing library.
Related #2922
Does this PR introduce a breaking change?
No
Other information
GSoC task of @arpitBhalla