Skip to content

[Tab] Added New Component: TabView & TabView.Item #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flyingcircle merged 13 commits into from
Jun 9, 2021
Merged

[Tab] Added New Component: TabView & TabView.Item #2983

flyingcircle merged 13 commits into from
Jun 9, 2021

Conversation

@arpitBhalla
Copy link
Member

@arpitBhalla arpitBhalla commented Apr 20, 2021 •
edited
Loading

  • Component
  • Docs
  • Demo

@arpitBhalla arpitBhalla changed the title Added New SubComponent Added New SubComponent: Tab.Panel & Tab.View Apr 20, 2021
@arpitBhalla arpitBhalla marked this pull request as draft April 20, 2021 16:48
@codecov
Copy link

codecov bot commented Apr 20, 2021 •
edited
Loading

Codecov Report

Merging #2983 (cc6002c) into next (09d6f78) will decrease coverage by 0.41%.
The diff coverage is 61.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2983      +/-   ##
==========================================
- Coverage   82.83%   82.42%   -0.42%     
==========================================
  Files          61       62       +1     
  Lines        1451     1485      +34     
  Branches      643      652       +9     
==========================================
+ Hits         1202     1224      +22     
- Misses        247      259      +12     
  Partials        2        2
Impacted Files Coverage Δ
src/divider/Divider.tsx 100.00% <ø> (ø)
src/tab/Tab.tsx 89.28% <ø> (ø)
src/tab/TabView.tsx 61.76% <61.76%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d6f78...cc6002c. Read the comment docs.

@arpitBhalla arpitBhalla changed the title Added New SubComponent: Tab.Panel & Tab.View [Tab] Added New SubComponent: Tab.Panel & Tab.View May 6, 2021
@arpitBhalla
Copy link
Member Author

arpitBhalla commented May 9, 2021

@flyingcircle can this be added to RNE?

@arpitBhalla arpitBhalla changed the title [Tab] Added New SubComponent: Tab.Panel & Tab.View [Tab] Added New SubComponent: Tab.View & Tab.ViewItem May 16, 2021
@arpitBhalla arpitBhalla changed the title [Tab] Added New SubComponent: Tab.View & Tab.ViewItem [Tab] Added New SubComponent: TabView & TabView.Item Jun 6, 2021
@arpitBhalla arpitBhalla marked this pull request as ready for review June 7, 2021 14:34
@arpitBhalla arpitBhalla changed the title [Tab] Added New SubComponent: TabView & TabView.Item [Tab] Added New Component: TabView & TabView.Item Jun 7, 2021
@flyingcircle flyingcircle merged commit d8885af into react-native-elements:next Jun 9, 2021
@arpitBhalla arpitBhalla deleted the tab-pager branch June 9, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arpitBhalla @flyingcircle